From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83126 invoked by alias); 22 Mar 2017 23:35:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 83109 invoked by uid 89); 22 Mar 2017 23:35:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=independent X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Mar 2017 23:35:49 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v2MNZfwC002222; Wed, 22 Mar 2017 18:35:41 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v2MNZb7w002215; Wed, 22 Mar 2017 18:35:37 -0500 Date: Wed, 22 Mar 2017 23:35:00 -0000 From: Segher Boessenkool To: Kelvin Nilsen Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH,rs6000] Handle conflicting target options -mno-power9-vector and -mcpu=power9 Message-ID: <20170322233535.GM4402@gate.crashing.org> References: <9b8253e6-794f-0c52-1ed1-f60b9a27be80@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b8253e6-794f-0c52-1ed1-f60b9a27be80@linux.vnet.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg01200.txt.bz2 On Wed, Mar 22, 2017 at 11:44:49AM -0600, Kelvin Nilsen wrote: > Internal testing recently revealed that use of the -mno-power9-vector > target option in combination with the -mcpu=power9 target option > results in termination of gcc with the error message: > > power9-dform requires power9-vector > In both cases, the preferred behavior is that the target option > -mno-power9-vector causes power9-dform to be automatically disabled. > This patch implements the preferred behavior and adds a test case to > demonstrate the fix. Or it could do -mpower9-dform-scalar but disable -mpower9-dform-vector? That seems more reasonable. Ideally none of the -mpower9-dform* or -mpower9-vector options would exist at all, of course. > 2017-03-21 Kelvin Nilsen > > * config/rs6000/rs6000.c (rs6000_option_override_internal): Change > handling of certain combinations of target options, including the > combinations -mpower8-vector vs. -mno-vsx, -mpower8-vector vs. > -mno-power8-vector, and -mpower9_dform vs. -mno-power9-vector. Those other changes are independent? Segher