From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96850 invoked by alias); 23 Mar 2017 10:37:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 96828 invoked by uid 89); 23 Mar 2017 10:37:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HX-Greylist:Thu X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Mar 2017 10:37:42 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F23DB85365; Thu, 23 Mar 2017 10:37:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F23DB85365 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F23DB85365 Received: from tucnak.zalov.cz (ovpn-116-72.ams2.redhat.com [10.36.116.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 997A918517; Thu, 23 Mar 2017 10:37:42 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v2NAbdbR028869; Thu, 23 Mar 2017 11:37:39 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v2NAbcFl028868; Thu, 23 Mar 2017 11:37:38 +0100 Date: Thu, 23 Mar 2017 10:37:00 -0000 From: Jakub Jelinek To: Alexander Monakov Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/5] omp-offload: implement SIMT privatization, part 2 Message-ID: <20170323103738.GN11094@tucnak> Reply-To: Jakub Jelinek References: <1490197595-31938-1-git-send-email-amonakov@ispras.ru> <1490197595-31938-4-git-send-email-amonakov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490197595-31938-4-git-send-email-amonakov@ispras.ru> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg01210.txt.bz2 On Wed, Mar 22, 2017 at 06:46:33PM +0300, Alexander Monakov wrote: > @@ -1669,6 +1672,93 @@ make_pass_oacc_device_lower (gcc::context *ctxt) > return new pass_oacc_device_lower (ctxt); > } > > + > + I'd avoid the empty line after ^L. > @@ -1694,6 +1785,20 @@ execute_omp_device_lower () > case IFN_GOMP_USE_SIMT: > rhs = vf == 1 ? integer_zero_node : integer_one_node; > break; > + case IFN_GOMP_SIMT_ENTER: > + rhs = vf == 1 ? gimple_call_arg (stmt, 0) : NULL_TREE; > + goto simtreg_enter_exit; > + case IFN_GOMP_SIMT_ENTER_ALLOC: > + if (vf != 1) > + ompdevlow_adjust_simt_enter (&gsi, ®implify); > + rhs = vf == 1 ? null_pointer_node : NULL_TREE; > + goto simtreg_enter_exit; > + case IFN_GOMP_SIMT_EXIT: > +simtreg_enter_exit: Please align the label below case, instead of start of the line. > + if (vf != 1) > + continue; > + unlink_stmt_vdef (stmt); This is weird. AFAIK unlink_stmt_vdef just replaces the uses of the vdef of that stmt with the vuse, but it still keeps the vdef (and vuse) around on the stmt, typically it is used when you are removing that stmt, but that is not the case here. So why are you doing it and not say removing the vdef? Jakub