From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8045 invoked by alias); 24 Mar 2017 23:37:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8035 invoked by uid 89); 24 Mar 2017 23:37:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:617 X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Mar 2017 23:37:49 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v2ONbk2n002717; Fri, 24 Mar 2017 18:37:47 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v2ONbkp4002716; Fri, 24 Mar 2017 18:37:46 -0500 Date: Sat, 25 Mar 2017 00:16:00 -0000 From: Segher Boessenkool To: Jakub Jelinek Cc: Jeff Law , Richard Henderson , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Don't cross-jump in between frame related and non-frame related insns (PR target/80102, take 3) Message-ID: <20170324233746.GT4402@gate.crashing.org> References: <20170320211520.GO11094@tucnak> <20170321074143.GT11094@tucnak> <20170321175334.GY11094@tucnak> <20170321202146.GA11094@tucnak> <3dea59bf-656e-beeb-fc7b-f5e796ba167b@redhat.com> <20170324130442.GJ11094@tucnak> <09d36f6b-a467-3110-7ae3-aae5f393d77c@redhat.com> <20170324193616.GV11094@tucnak> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170324193616.GV11094@tucnak> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg01341.txt.bz2 Hi! On Fri, Mar 24, 2017 at 08:36:16PM +0100, Jakub Jelinek wrote: > + /* Skip over reg notes not related to CFI information. */ > + while (n1) > + { > + for (i = 0; i < ARRAY_SIZE (cfa_note_kinds) - 1; i++) > + if (REG_NOTE_KIND (n1) == cfa_note_kinds[i]) > + break; > + if (i != ARRAY_SIZE (cfa_note_kinds)) > + break; > + n1 = XEXP (n1, 1); > + } Maybe factor out reg_note_is_cfa_note and/or insns_have_identical_cfa_notes functions? The patch looks fine to me btw. Thanks for working on this! Segher