public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Uncomment std::reference_wrapper tests that no longer fail
@ 2017-04-03 17:20 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2017-04-03 17:20 UTC (permalink / raw)
  To: libstdc++, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

I think this started working when I made std::reference_wrapper use
std::__invoke, so we can uncomment the tests.

	* testsuite/20_util/reference_wrapper/invoke.cc: Uncomment tests
	that no longer fail.

Tested powerpc64le-linux, committed to trunk.



[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1602 bytes --]

commit fef7c523742f474bb3322bd58b7be27dd088ed7d
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Apr 3 16:55:31 2017 +0100

    Uncomment std::reference_wrapper tests that no longer fail
    
    	* testsuite/20_util/reference_wrapper/invoke.cc: Uncomment tests
    	that no longer fail.

diff --git a/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke.cc b/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke.cc
index 8fd5470..c4a4537 100644
--- a/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke.cc
+++ b/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke.cc
@@ -73,8 +73,7 @@ void test01()
   int (::X::* p_foo_c)(float) const = &::X::foo_c;
   int (::X::* p_foo_v)(float) volatile = &::X::foo_v;
   int (::X::* p_foo_cv)(float) const volatile = &::X::foo_cv;
-  int (::X::* p_foo_varargs)(float, ...) __attribute__((unused))
-    = &::X::foo_varargs;
+  int (::X::* p_foo_varargs)(float, ...) = &::X::foo_varargs;
   int ::X::* p_bar = &::X::bar;
 
   const float pi = 3.14;
@@ -96,10 +95,10 @@ void test01()
   VERIFY(ref(p_foo_v)(xp, pi) == 3);
   VERIFY(ref(p_foo_cv)(x, pi) == 3);
   VERIFY(ref(p_foo_cv)(xp, pi) == 3);
-  // VERIFY(ref(p_foo_varargs)(x, pi) == 3);
-  // VERIFY(ref(p_foo_varargs)(xp, pi, 1, 1) == 3);
-  // VERIFY(ref(p_foo_varargs)(x, pi, 1, 1) == 3);
-  // VERIFY(ref(p_foo_varargs)(xp, pi) == 3);
+  VERIFY(ref(p_foo_varargs)(x, pi) == 3);
+  VERIFY(ref(p_foo_varargs)(xp, pi, 1, 1) == 3);
+  VERIFY(ref(p_foo_varargs)(x, pi, 1, 1) == 3);
+  VERIFY(ref(p_foo_varargs)(xp, pi) == 3);
 
   // Member data pointers
   VERIFY(ref(p_bar)(x) == 17);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-04-03 17:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-03 17:20 [PATCH] Uncomment std::reference_wrapper tests that no longer fail Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).