From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25265 invoked by alias); 3 Apr 2017 17:20:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25240 invoked by uid 89); 3 Apr 2017 17:20:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Apr 2017 17:20:36 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C66D18046A; Mon, 3 Apr 2017 17:20:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C66D18046A Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C66D18046A Received: from localhost (unknown [10.33.36.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7180A83802; Mon, 3 Apr 2017 17:20:34 +0000 (UTC) Date: Mon, 03 Apr 2017 17:20:00 -0000 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH] Uncomment std::reference_wrapper tests that no longer fail Message-ID: <20170403172033.GA18127@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-04/txt/msg00100.txt.bz2 --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-length: 252 I think this started working when I made std::reference_wrapper use std::__invoke, so we can uncomment the tests. * testsuite/20_util/reference_wrapper/invoke.cc: Uncomment tests that no longer fail. Tested powerpc64le-linux, committed to trunk. --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" Content-length: 1602 commit fef7c523742f474bb3322bd58b7be27dd088ed7d Author: Jonathan Wakely Date: Mon Apr 3 16:55:31 2017 +0100 Uncomment std::reference_wrapper tests that no longer fail * testsuite/20_util/reference_wrapper/invoke.cc: Uncomment tests that no longer fail. diff --git a/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke.cc b/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke.cc index 8fd5470..c4a4537 100644 --- a/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke.cc +++ b/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke.cc @@ -73,8 +73,7 @@ void test01() int (::X::* p_foo_c)(float) const = &::X::foo_c; int (::X::* p_foo_v)(float) volatile = &::X::foo_v; int (::X::* p_foo_cv)(float) const volatile = &::X::foo_cv; - int (::X::* p_foo_varargs)(float, ...) __attribute__((unused)) - = &::X::foo_varargs; + int (::X::* p_foo_varargs)(float, ...) = &::X::foo_varargs; int ::X::* p_bar = &::X::bar; const float pi = 3.14; @@ -96,10 +95,10 @@ void test01() VERIFY(ref(p_foo_v)(xp, pi) == 3); VERIFY(ref(p_foo_cv)(x, pi) == 3); VERIFY(ref(p_foo_cv)(xp, pi) == 3); - // VERIFY(ref(p_foo_varargs)(x, pi) == 3); - // VERIFY(ref(p_foo_varargs)(xp, pi, 1, 1) == 3); - // VERIFY(ref(p_foo_varargs)(x, pi, 1, 1) == 3); - // VERIFY(ref(p_foo_varargs)(xp, pi) == 3); + VERIFY(ref(p_foo_varargs)(x, pi) == 3); + VERIFY(ref(p_foo_varargs)(xp, pi, 1, 1) == 3); + VERIFY(ref(p_foo_varargs)(x, pi, 1, 1) == 3); + VERIFY(ref(p_foo_varargs)(xp, pi) == 3); // Member data pointers VERIFY(ref(p_bar)(x) == 17); --OXfL5xGRrasGEqWY--