From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105863 invoked by alias); 3 Apr 2017 19:07:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105848 invoked by uid 89); 3 Apr 2017 19:07:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Apr 2017 19:06:59 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A51AF338874; Mon, 3 Apr 2017 19:06:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A51AF338874 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A51AF338874 Received: from localhost (unknown [10.33.36.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4597E1811A; Mon, 3 Apr 2017 19:06:59 +0000 (UTC) Date: Mon, 03 Apr 2017 19:07:00 -0000 From: Jonathan Wakely To: Mike Stump Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix typos in comments throughout source tree Message-ID: <20170403190658.GL4425@redhat.com> References: <20170403175316.GH4425@redhat.com> <1ECDB5FA-6819-4A7D-B007-60B53AA53E03@mrs.kithrup.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-04/txt/msg00107.txt.bz2 On 03/04/17 11:48 -0700, Mike Stump wrote: >[ dup, I sent the wrong from the wrong email address, you might not see it because of that ] > >> On Apr 3, 2017, at 11:47 AM, Mike Stump wrote: >> >> On Apr 3, 2017, at 10:53 AM, Jonathan Wakely wrote: >>> >>> This fixes lots of typos throughout the tree. Can this be committed to >>> trunk as obvious? >> >> Yes, it can. However, I like it when even this patch is reviewed. I reviewed it, looks good. >> >> You missed initialisers -> initializers. Ah yes, in a couple of places. I think the original email about these typos only covered words beginning with the letters A to E, so there are bound to be lots more typos unfixed :-) >> Not sure I like datastructures, should be data structures? Will do. I also forgot to do something about the "accestor ???" part We provide accestor to the inline_summary datastructure and basic logic updating the parameters when inlining is performed. I don't know what that's supposed to say. "access"? "accessors"? >> figure out that poth parameters -> figure out that both parameters I'll fix that. >>> I've bootstrapped the C and C++ compilers, but not Ada, and of course >>> not compiled all the target changes in gcc/config/* >>> >>> Is one big commit OK, or one per-ChangeLog? Or something else? >> >> I'd just do one big commit. > Will do, thanks.