From: Jakub Jelinek <jakub@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Don't error about x86 return value in SSE reg (or x86 reg) or argument in SSE reg too early (PR target/80298)
Date: Wed, 05 Apr 2017 08:20:00 -0000 [thread overview]
Message-ID: <20170405082014.GO17461@tucnak> (raw)
In-Reply-To: <CAFULd4ZmYZcnyBw2DBruo9J8s3J2e_Xq9pw7871rX54yb7771w@mail.gmail.com>
On Wed, Apr 05, 2017 at 10:12:02AM +0200, Uros Bizjak wrote:
> Oh, I forgot to point out that on x86_64 ABI specifies MMX values in
> SSE registers.
I know it does. And if people have their own function that returns
__m64 or takes such arguments, they surely have to.
The question is only about the case when no function (in the assembly)
returns in SSE registers nor gets arguments in them, when all the
MMX code is inside of a function.
With your patch, it is - the MMX intrinsics are functions and we error on
them even when they are inlined.
With my patch we count only the non-inlined functions, something we emit
assembly for or call them from other TUs.
If you think requiring SSE for MMX always in 64-bit code is fine, even
when not strictly needed (as in, you really don't need SSE ISA to execute
such code, although there are no CPUs without that HW), so be it, then
let's go with your patch.
Jakub
next prev parent reply other threads:[~2017-04-05 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 19:24 Jakub Jelinek
2017-04-05 7:42 ` Uros Bizjak
2017-04-05 8:00 ` Jakub Jelinek
2017-04-05 8:12 ` Uros Bizjak
2017-04-05 8:20 ` Jakub Jelinek [this message]
2017-04-05 8:26 ` Uros Bizjak
2017-04-05 8:29 ` Jakub Jelinek
2017-04-05 15:37 ` Uros Bizjak
2017-04-06 18:37 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405082014.GO17461@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).