From: Segher Boessenkool <segher@kernel.crashing.org>
To: Pat Haugen <pthaugen@linux.vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH, rs6000] Update Power9 scheduling of vector and vector load insns
Date: Fri, 07 Apr 2017 17:30:00 -0000 [thread overview]
Message-ID: <20170407172942.GW4402@gate.crashing.org> (raw)
In-Reply-To: <38e578a5-418d-fcc5-4610-b9788738ec38@linux.vnet.ibm.com>
On Fri, Apr 07, 2017 at 11:58:15AM -0500, Pat Haugen wrote:
> The following patch changes the method of scheduling vector and vector
> load insns. Before it tried to pair up like insns and interleave the
> pairs, resulting in something like L1L2V1V2. The preferred scheduling is
> now to just interleave the insns, resulting in L1V1L2V2. If interleaving
> fails, fall back to pairing like insns.
> + 1 : A vecload or vector insn has been issued and a candidate for
> + for pairing has been found and moved to the end of the ready
Duplicate word ("for for").
> + if (is_power9_pairable_vec_type (get_attr_type
> + (ready[pos])))
A good way to battle long lines is to introduce another local var.
Okay for trunk and branch (with the duplicate word fixed, and do
whatever you think best with the long line). Thanks,
Segher
prev parent reply other threads:[~2017-04-07 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 16:58 Pat Haugen
2017-04-07 17:30 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407172942.GW4402@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pthaugen@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).