public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Martin Jambor <mjambor@suse.cz>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: Jakub Jelinek <jakub@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [hsa] Integrate into the existing accelerator framework, libgomp plugin
Date: Sun, 09 Apr 2017 16:15:00 -0000	[thread overview]
Message-ID: <20170409161526.xvvtiwvo3rkjkpj2@virgil.suse.cz> (raw)
In-Reply-To: <87shlngvar.fsf@euler.schwinge.homeip.net>

On Wed, Apr 05, 2017 at 09:36:44AM +0200, Thomas Schwinge wrote:
> Hi!
> 
> On Tue, 9 Jun 2015 16:43:57 +0200, Martin Jambor <mjambor@suse.cz> wrote:
> > [hsa libgomp plugin]
> 
> > I'm looking forward to any comments and suggestions, meanwhile I have
> > committed the patch to the branch as r224284.
> 
> Commenting better late than never?  ;-)
> 
> Is there a specific reason why you're not using the standard
> GOMP_PLUGIN_debug interface guarded by the GOMP_DEBUG environment
> variable, and instead essentially re-implement that functionality guarded
> by a new HSA_DEBUG environment variable?  (I might be talked into
> creating the obvious patch.)

No, no reason at all, I did not now about GOMP_PLUGIN_debug.  You're
welcome to create the patch (or I will do that after I wade through my
email and other backlogs).

Thanks for pointing it out,

Martin

      reply	other threads:[~2017-04-09 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 14:52 Martin Jambor
2017-04-05  7:37 ` Thomas Schwinge
2017-04-09 16:15   ` Martin Jambor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170409161526.xvvtiwvo3rkjkpj2@virgil.suse.cz \
    --to=mjambor@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).