From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119737 invoked by alias); 5 May 2017 13:08:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119213 invoked by uid 89); 5 May 2017 13:08:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:64a28bc, H*MI:sk:64a28bc, H*f:sk:64a28bc, Hx-languages-length:1642 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 May 2017 13:08:18 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE75080C22; Fri, 5 May 2017 13:08:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CE75080C22 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CE75080C22 Received: from localhost (unknown [10.33.36.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4FB2917A8F; Fri, 5 May 2017 13:08:19 +0000 (UTC) Date: Fri, 05 May 2017 13:14:00 -0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: Bump version namespace and remove _Rb_tree useless template parameter Message-ID: <20170505130818.GC5109@redhat.com> References: <64a28bc2-0d9c-e83b-b582-5baac8470d82@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <64a28bc2-0d9c-e83b-b582-5baac8470d82@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-05/txt/msg00396.txt.bz2 On 04/05/17 22:16 +0200, François Dumont wrote: >Hi > > Here is the patch to remove the useless _Is_pod_comparator >_Rb_tree_impl template parameter. As this is an ABI breaking change it >is limited to the versioned namespace mode and the patch also bump the >namespace version. > > Working on this patch I wonder if the gnu-versioned-namespace.ver >is really up to date. The list of export expressions is far smaller >than the one in gnu.ver. Because it uses wildcards that match all symbols, because using the versioned namespace everything gets the same symbol version. We don't need to assign different versions to different symbols. >Would the testsuite show that some symbols >are not properly exported ? Yes (as long as we have a test that exercises the feature). > Bump version namespace. > * config/abi/pre/gnu-versioned-namespace.ver: Bump version namespace > from __7 to __8. Bump GLIBCXX_7.0 into GLIBCXX_8.0. > * include/bits/c++config: Adapt. > * include/bits/regex.h: Adapt. > * include/experimental/bits/fs_fwd.h: Adapt. > * include/experimental/bits/lfts_config.h: Adapt. > * include/std/variant: Adapt. > * python/libstdcxx/v6/printers.py: Adapt. > * testsuite/libstdc++-prettyprinters/48362.cc: Adapt. > * include/bits/stl_tree.h (_Rb_tree_impl<>): Remove _Is_pod_comparator > template parameter when version namespace is active. The patch also needs to update libtool_VERSION in acinclude.m4 so that the shared library goes from libstdc++.so.7 to libstdc++.so.8 (because after this change we're absolutely not compatible with libstdc++.so.7)