From: Prakhar Bahuguna <prakhar.bahuguna@arm.com>
To: <gcc-patches@gcc.gnu.org>
Cc: <nd@arm.com>, <Richard.Earnshaw@arm.com>,
<Ramana.Radhakrishnan@arm.com>, <Kyrylo.Tkachov@arm.com>
Subject: [PING][PATCH, GCC/ARM] Only test tls-disable-literal-pool.c if target supports native TLS
Date: Fri, 19 May 2017 12:33:00 -0000 [thread overview]
Message-ID: <20170519122958.jtxtqprsp44mlyau@e107464-lin.cambridge.arm.com> (raw)
On 11/05/2017 14:54:37, Prakhar Bahuguna wrote:
> tls-disable-literal-pool.c should only be run if the toolchain and target
> support native thread-local storage rather than emulated TLS. This patch also
> improves the matching of the error message.
>
> testsuite/ChangeLog:
>
> 2017-05-11 Prakhar Bahuguna <prakhar.bahuguna@arm.com>
>
> * gcc.target/arm/tls-disable-literal-pool.c: Change
> require-effective-target to tls_native.
> Move dg-error to return statement line and change to dg-message.
>
> Testing done: Regression testing for ARMv7-M with a TLS-enabled toolchain and a
> TLS-disabled toolchain.
>
> Okay for stage1?
>
> --
>
> Prakhar Bahuguna
> From 84837978d480a1abcebe7b4d2ac21af0eb6645b4 Mon Sep 17 00:00:00 2001
> From: Prakhar Bahuguna <prakhar.bahuguna@arm.com>
> Date: Thu, 11 May 2017 13:24:39 +0100
> Subject: [PATCH] Only test tls-disable-literal-pool.c if target supports
> native TLS
>
> This test should only be run if the toolchain and target support native
> thread-local storage rather than emulated TLS.
> ---
> gcc/testsuite/gcc.target/arm/tls-disable-literal-pool.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/arm/tls-disable-literal-pool.c b/gcc/testsuite/gcc.target/arm/tls-disable-literal-pool.c
> index fe14a6b132c..283201fdd97 100644
> --- a/gcc/testsuite/gcc.target/arm/tls-disable-literal-pool.c
> +++ b/gcc/testsuite/gcc.target/arm/tls-disable-literal-pool.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-require-effective-target tls } */
> +/* { dg-require-effective-target tls_native } */
> /* { dg-require-effective-target arm_cortex_m } */
> /* { dg-require-effective-target arm_thumb2_ok } */
> /* { dg-options "-mslow-flash-data" } */
> @@ -9,7 +9,6 @@ __thread int x = 0;
> int
> bar ()
> {
> - return x;
> + return x; /* { dg-message "sorry, unimplemented: accessing thread-local storage is not currently supported with -mpure-code or -mslow-flash-data" } */
> }
>
> -/* { dg-error "accessing thread-local storage is not currently supported with -mpure-code or -mslow-flash-data" "" { target *-*-* } 12 } */
> --
> 2.11.0
>
Ping.
--
Prakhar Bahuguna
next reply other threads:[~2017-05-19 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 12:33 Prakhar Bahuguna [this message]
2017-05-19 12:51 ` Kyrill Tkachov
2017-05-29 12:56 ` Christophe Lyon
2017-05-30 7:47 ` Prakhar Bahuguna
2017-05-30 12:12 ` Christophe Lyon
2017-05-30 12:29 ` Prakhar Bahuguna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519122958.jtxtqprsp44mlyau@e107464-lin.cambridge.arm.com \
--to=prakhar.bahuguna@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).