public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Xi Ruoyao <ryxi@stu.xidian.edu.cn>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] Implement non-trivial std::random_device::entropy (PR libstdc++/67578)
Date: Mon, 22 May 2017 14:10:00 -0000	[thread overview]
Message-ID: <20170522135002.GJ4527@redhat.com> (raw)
In-Reply-To: <1495460501.29130.6.camel@stu.xidian.edu.cn>

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

On 22/05/17 21:41 +0800, Xi Ruoyao wrote:
>On 2017-05-22 14:00 +0100, Jonathan Wakely wrote:
>> On 18/05/17 19:27 +0800, Xi Ruoyao wrote:
>> > This patch use ioctl to get entropy of std::random_device using
>> > /dev/random and /dev/urandom.
>>
>> This is a nice addition, thanks.
>>
>> N.B. I couldn't apply your patch, several lines had U+00A0 (i.e.
>> NO-BREAK SPACE) characters where normal spaces should be. I don't know
>> if this is something your mail client did, but maybe attaching the
>> patch as a multipart message rather than including it inline in the
>> body will prevent it in future.
>
>Oh no...  Seems my email client destroyed my patch. I'll attach the
>patch next time.  Please wait for PATCH v2.

OK, will do. I missed part of the required changes when adding a new
symbol version, see the attached patch.



[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 693 bytes --]

diff --git a/libstdc++-v3/testsuite/util/testsuite_abi.cc b/libstdc++-v3/testsuite/util/testsuite_abi.cc
index 953c907..ee7572e 100644
--- a/libstdc++-v3/testsuite/util/testsuite_abi.cc
+++ b/libstdc++-v3/testsuite/util/testsuite_abi.cc
@@ -235,7 +235,7 @@ check_version(symbol& test, bool added)
 	test.version_status = symbol::incompatible;
 
       // Check that added symbols are added in the latest pre-release version.
-      bool latestp = (test.version_name == "GLIBCXX_3.4.23"
+      bool latestp = (test.version_name == "GLIBCXX_3.4.24"
 		     || test.version_name == "CXXABI_1.3.11"
 		     || test.version_name == "CXXABI_FLOAT128"
 		     || test.version_name == "CXXABI_TM_1");

  reply	other threads:[~2017-05-22 13:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 12:15 Xi Ruoyao
2017-05-22 13:21 ` Jonathan Wakely
2017-05-22 13:50   ` Xi Ruoyao
2017-05-22 14:10     ` Jonathan Wakely [this message]
2017-05-22 14:19       ` Xi Ruoyao
2017-05-23 12:11         ` Jonathan Wakely
2017-05-22 14:30       ` [PATCH v2] " Xi Ruoyao
2017-05-23 16:22         ` Jonathan Wakely
2017-05-24 19:28           ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170522135002.GJ4527@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ryxi@stu.xidian.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).