From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40922 invoked by alias); 22 May 2017 13:50:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40905 invoked by uid 89); 22 May 2017 13:50:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HTo:D*cn, HTo:D*edu.cn X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 May 2017 13:50:02 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A4A3C81127; Mon, 22 May 2017 13:50:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A4A3C81127 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A4A3C81127 Received: from localhost (unknown [10.33.36.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 403F27BAE3; Mon, 22 May 2017 13:50:04 +0000 (UTC) Date: Mon, 22 May 2017 14:10:00 -0000 From: Jonathan Wakely To: Xi Ruoyao Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH] Implement non-trivial std::random_device::entropy (PR libstdc++/67578) Message-ID: <20170522135002.GJ4527@redhat.com> References: <1495106850.1663.8.camel@stu.xidian.edu.cn> <20170522130058.GF4527@redhat.com> <1495460501.29130.6.camel@stu.xidian.edu.cn> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="wLAMOaPNJ0fu1fTG" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1495460501.29130.6.camel@stu.xidian.edu.cn> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-05/txt/msg01674.txt.bz2 --wLAMOaPNJ0fu1fTG Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-length: 830 On 22/05/17 21:41 +0800, Xi Ruoyao wrote: >On 2017-05-22 14:00 +0100, Jonathan Wakely wrote: >> On 18/05/17 19:27 +0800, Xi Ruoyao wrote: >> > This patch use ioctl to get entropy of std::random_device using >> > /dev/random and /dev/urandom. >> >> This is a nice addition, thanks. >> >> N.B. I couldn't apply your patch, several lines had U+00A0 (i.e. >> NO-BREAK SPACE) characters where normal spaces should be. I don't know >> if this is something your mail client did, but maybe attaching the >> patch as a multipart message rather than including it inline in the >> body will prevent it in future. > >Oh no...  Seems my email client destroyed my patch. I'll attach the >patch next time.  Please wait for PATCH v2. OK, will do. I missed part of the required changes when adding a new symbol version, see the attached patch. --wLAMOaPNJ0fu1fTG Content-Type: text/x-patch; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" Content-length: 693 diff --git a/libstdc++-v3/testsuite/util/testsuite_abi.cc b/libstdc++-v3/testsuite/util/testsuite_abi.cc index 953c907..ee7572e 100644 --- a/libstdc++-v3/testsuite/util/testsuite_abi.cc +++ b/libstdc++-v3/testsuite/util/testsuite_abi.cc @@ -235,7 +235,7 @@ check_version(symbol& test, bool added) test.version_status = symbol::incompatible; // Check that added symbols are added in the latest pre-release version. - bool latestp = (test.version_name == "GLIBCXX_3.4.23" + bool latestp = (test.version_name == "GLIBCXX_3.4.24" || test.version_name == "CXXABI_1.3.11" || test.version_name == "CXXABI_FLOAT128" || test.version_name == "CXXABI_TM_1"); --wLAMOaPNJ0fu1fTG--