public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: C/C++ OpenACC: acc_pcopyin, acc_pcreate
Date: Tue, 23 May 2017 11:08:00 -0000	[thread overview]
Message-ID: <20170523110715.GQ8499@tucnak> (raw)
In-Reply-To: <87bmqlynkn.fsf@hertz.schwinge.homeip.net>

On Mon, May 22, 2017 at 04:26:48PM +0200, Thomas Schwinge wrote:
> In <openacc.h>, we currently describe acc_pcopyin, acc_pcreate as "old
> names", but they're not "old" but really "alternative names", with the
> intention to provide them at symbol level, not via "#define"s.  OK for
> trunk?

No.

>             * libgomp.map (OACC_2.0): Add "acc_pcopyin", and "acc_pcreate".

> --- libgomp/libgomp.map
> +++ libgomp/libgomp.map
> @@ -335,6 +335,7 @@ OACC_2.0 {
>  	acc_copyin_64_h_;
>  	acc_copyin_array_h_;
>  	acc_present_or_copyin;
> +	acc_pcopyin;
>  	acc_present_or_copyin_32_h_;
>  	acc_present_or_copyin_64_h_;
>  	acc_present_or_copyin_array_h_;
> @@ -343,6 +344,7 @@ OACC_2.0 {
>  	acc_create_64_h_;
>  	acc_create_array_h_;
>  	acc_present_or_create;
> +	acc_pcreate;
>  	acc_present_or_create_32_h_;
>  	acc_present_or_create_64_h_;
>  	acc_present_or_create_array_h_;

This is just wrong, new symbols should never be added to an existing symbol
version after a GCC version with that symbol version has been released.
You can add it into OACC_2.0.1, or OACC_1.0, or whatever else, but certainly
not into OACC_2.0.

Another option is just to use something like glibc's sys/cdefs.h
__REDIRECT_NTH macro (including the __USER_LABEL_PREFIX__ stuff)
and just declare those functions as having the asm name of the corresponding
alias.  The openacc.h header is for use with GCC only anyway, right?
Unless OpenACC allows one to declare those functions himself and expect
to be able to call them...

	Jakub

  parent reply	other threads:[~2017-05-23 11:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 14:28 Thomas Schwinge
2017-05-22 15:23 ` Translate libgomp.oacc-c-c++-common/lib-32.c into Fortran (was: C/C++ OpenACC: acc_pcopyin, acc_pcreate) Thomas Schwinge
2017-05-23 11:12   ` Jakub Jelinek
2017-05-24 13:45     ` Translate libgomp.oacc-c-c++-common/lib-32.c into Fortran Thomas Schwinge
2017-05-23 11:08 ` Jakub Jelinek [this message]
2017-05-24 10:57   ` C/C++ OpenACC: acc_pcopyin, acc_pcreate Thomas Schwinge
2017-05-24 11:24     ` Jakub Jelinek
2017-05-24 13:41       ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523110715.GQ8499@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).