public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Xi Ruoyao <ryxi@stu.xidian.edu.cn>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH v2] Implement non-trivial std::random_device::entropy (PR libstdc++/67578)
Date: Tue, 23 May 2017 16:22:00 -0000	[thread overview]
Message-ID: <20170523161549.GE12306@redhat.com> (raw)
In-Reply-To: <1495463288.29130.18.camel@stu.xidian.edu.cn>

On 22/05/17 22:28 +0800, Xi Ruoyao wrote:
>The new patch is attached.  Just merged the patches you sent and fixed
>the ChangeLog of gnu.ver and testsuite_abi.cc.
>
>(For fun:  I had mistakenly attached the Vim .swp file of the patch
>and almost sent it. :-p)

Ha, that *definitely* wouldnt' have applied, but I think I'd have
noticed the reason sooner ;-)

I've committed the patch now - thanks.


>@@ -334,6 +335,7 @@ compatible.
>     <listitem><para>GCC 5.1.0: GLIBCXX_3.4.21, CXXABI_1.3.9</para></listitem>
>     <listitem><para>GCC 6.1.0: GLIBCXX_3.4.22, CXXABI_1.3.10</para></listitem>
>     <listitem><para>GCC 7.1.0: GLIBCXX_3.4.23, CXXABI_1.3.11</para></listitem>
>+    <listitem><para>GCC 8.0.0: GLIBCXX_3.4.24, CXXABI_1.3.10</para></listitem>

Oops, this should have been CXXABI_1.3.11, I fixed that before
committing it.

>+    if (static_cast<unsigned>(ent) > sizeof(result_type) * 8)
>+      return static_cast<double>(sizeof(result_type) * 8);

After committing it I realised this should use __CHAR_BIT__ instead of
hardcoding 8, which I'll fix shortly.


  reply	other threads:[~2017-05-23 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 12:15 [PATCH] " Xi Ruoyao
2017-05-22 13:21 ` Jonathan Wakely
2017-05-22 13:50   ` Xi Ruoyao
2017-05-22 14:10     ` Jonathan Wakely
2017-05-22 14:19       ` Xi Ruoyao
2017-05-23 12:11         ` Jonathan Wakely
2017-05-22 14:30       ` [PATCH v2] " Xi Ruoyao
2017-05-23 16:22         ` Jonathan Wakely [this message]
2017-05-24 19:28           ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523161549.GE12306@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ryxi@stu.xidian.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).