From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1573 invoked by alias); 26 May 2017 11:50:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1528 invoked by uid 89); 26 May 2017 11:50:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=47am, 47AM X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 May 2017 11:49:59 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC663448D93; Fri, 26 May 2017 11:50:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AC663448D93 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AC663448D93 Received: from tucnak.zalov.cz (unknown [10.36.118.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FC0017A75; Fri, 26 May 2017 11:50:01 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v4QBnwuN010501; Fri, 26 May 2017 13:49:59 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v4QBnvEY010500; Fri, 26 May 2017 13:49:57 +0200 Date: Fri, 26 May 2017 11:50:00 -0000 From: Jakub Jelinek To: Nathan Sidwell Cc: GCC Patches Subject: Re: [C++ PATCH] Reimplement ADL Message-ID: <20170526114957.GK8499@tucnak> Reply-To: Jakub Jelinek References: <4f2b3ce9-7f06-6a10-f1c9-4542b3651bd0@acm.org> <20170526075453.GJ8499@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg02034.txt.bz2 On Fri, May 26, 2017 at 07:35:47AM -0400, Nathan Sidwell wrote: > On 05/26/2017 03:54 AM, Jakub Jelinek wrote: > > On Thu, May 25, 2017 at 09:03:31AM -0400, Nathan Sidwell wrote: > > > This patch reimplements ADL. > > > I believe this broke > > FAIL: libgomp.c++/udr-12.C (test for excess errors) > > UNRESOLVED: libgomp.c++/udr-12.C compilation failed to produce executable > > In answer to my own question, Yes. Yes we should ADL the type. > > Fixed thusly. Thanks. > 2017-05-26 Nathan Sidwell > > * name-lookup.c (name_lookup::search_adl): ADL OMP UDR type args. > > Index: name-lookup.c > =================================================================== > --- name-lookup.c (revision 248488) > +++ name-lookup.c (working copy) > @@ -998,9 +998,11 @@ name_lookup::search_adl (tree fns, vec tree arg; > > FOR_EACH_VEC_ELT_REVERSE (*args, ix, arg) > - /* OMP reduction operators put a type as the first arg. I don't > - suppose we should ADL on that? */ > - if (!TYPE_P (arg)) > + /* OMP reduction operators put an ADL-significant type as the > + first arg. */ > + if (TYPE_P (arg)) > + adl_type (arg); > + else > adl_expr (arg); > > delete fn_set; Jakub