From: Prakhar Bahuguna <prakhar.bahuguna@arm.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>
Subject: Re: [PING][PATCH, GCC/ARM] Only test tls-disable-literal-pool.c if target supports native TLS
Date: Tue, 30 May 2017 07:47:00 -0000 [thread overview]
Message-ID: <20170530074414.ollfyunizvsrnnyh@e107464-lin.cambridge.arm.com> (raw)
In-Reply-To: <CAKdteOb=Ngvc6Cv-7KrY+Sg0=etRM10YvkL9zP30TfJHReOqww@mail.gmail.com>
On 29/05/2017 14:23:05, Christophe Lyon wrote:
> On 19 May 2017 at 14:29, Prakhar Bahuguna <prakhar.bahuguna@arm.com> wrote:
> > On 11/05/2017 14:54:37, Prakhar Bahuguna wrote:
> >> tls-disable-literal-pool.c should only be run if the toolchain and target
> >> support native thread-local storage rather than emulated TLS. This patch also
> >> improves the matching of the error message.
> >>
> >> testsuite/ChangeLog:
> >>
> >> 2017-05-11 Prakhar Bahuguna <prakhar.bahuguna@arm.com>
> >>
> >> * gcc.target/arm/tls-disable-literal-pool.c: Change
> >> require-effective-target to tls_native.
> >> Move dg-error to return statement line and change to dg-message.
> >>
> >> Testing done: Regression testing for ARMv7-M with a TLS-enabled toolchain and a
> >> TLS-disabled toolchain.
> >>
>
> Hi,
> Can you share more details on the configuration you used?
> In my testing, the only cortex-M config I have is arm-none-eabi
> --with-cpu=cortex-m3.
> Since arm-none-eabi means native-tls is disabled, this test is skipped.
> A constraint for me is that m3 was the only cortex-m cpu supported by qemu the
> last time I checked.
>
> Thanks,
>
> Christophe
>
Hi Christophe,
For a regular arm-none-eabi build, TLS is indeed disabled and the test should
be skipped. The diagnostic and test is meant to catch instances where the
toolchain has been built with native TLS enabled. This can be done either by
explicitly passing the --enable-tls configure flag for arm-none-eabi, or by
using an arm-none-linux-gnueabi[hf] toolchain and testing against an M-profile
target.
Hope this helps,
--
Prakhar Bahuguna
next prev parent reply other threads:[~2017-05-30 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 12:33 Prakhar Bahuguna
2017-05-19 12:51 ` Kyrill Tkachov
2017-05-29 12:56 ` Christophe Lyon
2017-05-30 7:47 ` Prakhar Bahuguna [this message]
2017-05-30 12:12 ` Christophe Lyon
2017-05-30 12:29 ` Prakhar Bahuguna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530074414.ollfyunizvsrnnyh@e107464-lin.cambridge.arm.com \
--to=prakhar.bahuguna@arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).