public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
Cc: gcc-patches@gcc.gnu.org, Francois.Bedard@synopsys.com
Subject: Re: [PATCH] [ARC] Fix tst_movb pattern.
Date: Tue, 30 May 2017 11:07:00 -0000	[thread overview]
Message-ID: <20170530110606.GD18313@embecosm.com> (raw)
In-Reply-To: <1495623262-7898-1-git-send-email-claziss@synopsys.com>

* Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com> [2017-05-24 12:54:22 +0200]:

> From: claziss <claziss@synopsys.com>
> 
> The tst_movb pattern is missing guarding when spitting.
> 
> gcc/
> 2017-05-24  Claudiu Zissulescu  <claziss@synopsys.com>
> 
> 	* config/arc/arc.md (tst_movb): Add guard when splitting.

Looks good. Sorry for introducing this issue.

Thanks,
Andrew




> 
> testsuite/
> 2017-05-24  Claudiu Zissulescu  <claziss@synopsys.com>
> 
> 	* gcc.target/arc/pr9001195952.c: New test.
> ---
>  gcc/config/arc/arc.md                       |  2 +-
>  gcc/testsuite/gcc.target/arc/pr9001195952.c | 11 +++++++++++
>  2 files changed, 12 insertions(+), 1 deletion(-)
>  create mode 100755 gcc/testsuite/gcc.target/arc/pr9001195952.c
> 
> diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md
> index e78abaa..d5510ae 100644
> --- a/gcc/config/arc/arc.md
> +++ b/gcc/config/arc/arc.md
> @@ -863,7 +863,7 @@ archs4xd, archs4xd_slow"
>     (clobber (match_scratch:SI 3 "=X,X,X,X,X,X,Rrq,Rrq,c"))]
>    "TARGET_NPS_BITOPS"
>    "movb.f.cl %3,%1,%p2,%p2,%s2"
> -  "reload_completed
> +  "TARGET_NPS_BITOPS && reload_completed
>     && (extract_constrain_insn_cached (insn), (which_alternative & ~1) != 6)"
>    [(set (match_dup 0) (match_dup 4))])
>  
> diff --git a/gcc/testsuite/gcc.target/arc/pr9001195952.c b/gcc/testsuite/gcc.target/arc/pr9001195952.c
> new file mode 100755
> index 0000000..252438d
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/arc/pr9001195952.c
> @@ -0,0 +1,11 @@
> +/* { dg-do compile } */
> +/* { dg-skip-if "" { ! { clmcpu } } } */
> +/* { dg-options "-mcpu=archs -Os -w -fpic" } */
> +
> +/* tst_movb split pattern is wrong for anything else than NPS
> +   chip.  */
> +__bswap_32___bsx() {
> +  int a = __builtin_bswap32(__bswap_32___bsx);
> +  if (a & 1048575)
> +    zlog_warn();
> +}
> -- 
> 1.9.1
> 

      reply	other threads:[~2017-05-30 11:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24 10:57 Claudiu Zissulescu
2017-05-30 11:07 ` Andrew Burgess [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530110606.GD18313@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=Claudiu.Zissulescu@synopsys.com \
    --cc=Francois.Bedard@synopsys.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).