From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128426 invoked by alias); 31 May 2017 15:40:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128403 invoked by uid 89); 31 May 2017 15:40:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=xx X-HELO: mail-wm0-f42.google.com Received: from mail-wm0-f42.google.com (HELO mail-wm0-f42.google.com) (74.125.82.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 May 2017 15:40:01 +0000 Received: by mail-wm0-f42.google.com with SMTP id b84so123933468wmh.0 for ; Wed, 31 May 2017 08:40:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bArqZaTiEzO4uqZcDNQSXJXvNXk6K7/BVMIUlRlweT0=; b=H7danSuzSQ6LhhmZec1A/sAxb1o0WSLCdNyqY75989Cj2gE/rqMbi8x1YEpK/DwnY+ 5lNoebLEz5enHDwGWtOQnoLC/2C6yDdODsZlNvE9tTwrIYw3VRETnw+nfy5JDM2yVUXa kdRFFvpyw2GGPQE40LhC2amL6UD3UGsyA8xhA8LP3g39StWLzQr9mXPo5gtRxH6fBZsB Mcd0RWPb5LjD7ADrn+NH9iuVxIjeTYs+uJKJKLXxhqRn3yoPRkj6Pc/G5RD8o5cG7p9I 9MLhVlfhnNnOGR0k0qNjMHRfm+edlJIRGdtCCkmKfFgc2Py+zQsOMlg7wmHbIBeqWD/P owHA== X-Gm-Message-State: AODbwcDvFTVYl4/wjGY204y1Eah7l6lHUjvBIzTsWddxVwxINedvx1iI 2MC0d7IseRH5FZK56+Y= X-Received: by 10.223.139.81 with SMTP id v17mr1405296wra.70.1496245203287; Wed, 31 May 2017 08:40:03 -0700 (PDT) Received: from localhost (host86-164-133-102.range86-164.btcentralplus.com. [86.164.133.102]) by smtp.gmail.com with ESMTPSA id n92sm15085680wrb.62.2017.05.31.08.40.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2017 08:40:02 -0700 (PDT) Date: Wed, 31 May 2017 15:40:00 -0000 From: Andrew Burgess To: Claudiu Zissulescu Cc: gcc-patches@gcc.gnu.org, Francois.Bedard@synopsys.com Subject: Re: [PATCH 5/7] [ARC] Update (non)commutative_binary_comparison patterns. Message-ID: <20170531154001.GG25719@embecosm.com> References: <1495189862-20533-1-git-send-email-claziss@synopsys.com> <1495189862-20533-6-git-send-email-claziss@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495189862-20533-6-git-send-email-claziss@synopsys.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg02381.txt.bz2 * Claudiu Zissulescu [2017-05-19 12:31:00 +0200]: > gcc/ > 2016-12-20 Claudiu Zissulescu > > * config/arc/arc.md (commutative_binary_comparison): Remove 'I' > constraint. It is not valid for the pattern. > (noncommutative_binary_comparison): Likewise. Looks good, thanks, Andrew > --- > gcc/config/arc/arc.md | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md > index c0ad86c..743a844 100644 > --- a/gcc/config/arc/arc.md > +++ b/gcc/config/arc/arc.md > @@ -948,15 +948,15 @@ > [(set (match_operand:CC_ZN 0 "cc_set_register" "") > (match_operator:CC_ZN 5 "zn_compare_operator" > [(match_operator:SI 4 "commutative_operator" > - [(match_operand:SI 1 "register_operand" "%c,c,c") > - (match_operand:SI 2 "nonmemory_operand" "cL,I,?Cal")]) > + [(match_operand:SI 1 "register_operand" "%c,c") > + (match_operand:SI 2 "nonmemory_operand" "cL,Cal")]) > (const_int 0)])) > - (clobber (match_scratch:SI 3 "=X,1,X"))] > + (clobber (match_scratch:SI 3 "=X,X"))] > "" > "%O4.f 0,%1,%2" > [(set_attr "type" "compare") > (set_attr "cond" "set_zn") > - (set_attr "length" "4,4,8")]) > + (set_attr "length" "4,8")]) > > ; for flag setting 'add' instructions like if (a+b) { ...} > ; the combiner needs this pattern > @@ -1050,15 +1050,15 @@ > [(set (match_operand:CC_ZN 0 "cc_set_register" "") > (match_operator:CC_ZN 5 "zn_compare_operator" > [(match_operator:SI 4 "noncommutative_operator" > - [(match_operand:SI 1 "register_operand" "c,c,c") > - (match_operand:SI 2 "nonmemory_operand" "cL,I,?Cal")]) > + [(match_operand:SI 1 "register_operand" "c,c") > + (match_operand:SI 2 "nonmemory_operand" "cL,Cal")]) > (const_int 0)])) > - (clobber (match_scratch:SI 3 "=X,1,X"))] > + (clobber (match_scratch:SI 3 "=X,X"))] > "TARGET_BARREL_SHIFTER || GET_CODE (operands[4]) == MINUS" > "%O4.f 0,%1,%2" > [(set_attr "type" "compare") > (set_attr "cond" "set_zn") > - (set_attr "length" "4,4,8")]) > + (set_attr "length" "4,8")]) > > (define_expand "bic_f_zn" > [(parallel > -- > 1.9.1 >