From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67586 invoked by alias); 31 May 2017 16:04:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67576 invoked by uid 89); 31 May 2017 16:04:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:10.28.84.14, Hx-languages-length:1185 X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 May 2017 16:04:43 +0000 Received: by mail-wm0-f52.google.com with SMTP id d127so25535204wmf.0 for ; Wed, 31 May 2017 09:04:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HA+Trrb3FhKj8IJXuByH8wjnxJLVplshBH3jsc2O9dY=; b=mEKBecVYZ/L6I07QiKRUwTHwqWn3jl+XSvqrYVcFrP635g7fuLnW7aPUSukUFDuuuC c8iCNB0bU6kOcTi0otQebm/P/7UyD7Djum+btY6aqkEF8UZH3zalqbBJBOizd08uJOxc kbvQQw11F3hsf02XwJX51DQZvjsQINOYBwSwjZoYLY7M7lVOhp4V6nw7j2ksFhTGz4SY +/6202LFQFk8IL5LHCzT0tSWhW1aRntU8/oGwhiIu+iFfK18IM8XenWgYZd3grq/HJbR aM+Yr1jP0uQkBjuL4dG2pEMN+ouJM4sqOUpo5qB6jLNI7afSZSOR6gW4Ayn2sXFPQWFe 4HAQ== X-Gm-Message-State: AODbwcD8ALlZGCvXo4LZIbZaNWeQwq7A/nwuLMk9pHwP1wwuWiEL1s8/ 9fDB363oUeKwAmYI X-Received: by 10.28.84.14 with SMTP id i14mr6404077wmb.81.1496246684387; Wed, 31 May 2017 09:04:44 -0700 (PDT) Received: from localhost (host86-164-133-102.range86-164.btcentralplus.com. [86.164.133.102]) by smtp.gmail.com with ESMTPSA id g77sm10571234wmd.19.2017.05.31.09.04.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2017 09:04:43 -0700 (PDT) Date: Wed, 31 May 2017 16:28:00 -0000 From: Andrew Burgess To: Claudiu Zissulescu Cc: gcc-patches@gcc.gnu.org, Francois.Bedard@synopsys.com Subject: Re: [PATCH 7/7] [ARC] Test against frame_pointer_needed in arc_can_eliminate. Message-ID: <20170531160442.GH25719@embecosm.com> References: <1495189862-20533-1-git-send-email-claziss@synopsys.com> <1495189862-20533-8-git-send-email-claziss@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495189862-20533-8-git-send-email-claziss@synopsys.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg02384.txt.bz2 * Claudiu Zissulescu [2017-05-19 12:31:02 +0200]: > arc_can_eliminate is using arc_frmae_pointer_required() which is wrong > as the frame_pointer_needed can be set on different conditions. Fix it > by calling arc_frame_pointer_needed(). > > gcc/ > 2017-01-09 Claudiu Zissulescu > > * config/arc/arc.c (arc_can_eliminate): Test against > arc_frame_pointer_needed. Looks good, thanks, Andrew > --- > gcc/config/arc/arc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c > index 0c4c901..aac1952 100644 > --- a/gcc/config/arc/arc.c > +++ b/gcc/config/arc/arc.c > @@ -4733,7 +4733,7 @@ arc_final_prescan_insn (rtx_insn *insn, rtx *opvec ATTRIBUTE_UNUSED, > static bool > arc_can_eliminate (const int from ATTRIBUTE_UNUSED, const int to) > { > - return to == FRAME_POINTER_REGNUM || !arc_frame_pointer_required (); > + return ((to == FRAME_POINTER_REGNUM) || !arc_frame_pointer_needed ()); > } > > /* Define the offset between two registers, one to be eliminated, and > -- > 1.9.1 >