public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: gcc-patches@gcc.gnu.org
Subject: [committed] Fix typo in Fortran OpenMP handling (PR fortran/80918)
Date: Fri, 02 Jun 2017 07:10:00 -0000	[thread overview]
Message-ID: <20170602071046.GL24023@tucnak> (raw)

Hi!

When backporting patches to 5.x, I've noticed a typo that causes us to
diagnose something that shouldn't be diagnosed.

Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk
and 7.2, queued for 6.x.

2017-06-02  Jakub Jelinek  <jakub@redhat.com>

	PR fortran/80918
	* openmp.c (resolve_omp_clauses): Fix a typo.

	* gfortran.dg/gomp/pr80918.f90: New test.

--- gcc/fortran/openmp.c.jj	2017-05-24 11:59:03.000000000 +0200
+++ gcc/fortran/openmp.c	2017-05-30 11:38:29.905964424 +0200
@@ -4381,7 +4381,7 @@ resolve_omp_clauses (gfc_code *code, gfc
 		    else
 		      resolve_oacc_data_clauses (n->sym, n->where, name);
 		  }
-		else if (list != OMP_CLAUSE_DEPEND
+		else if (list != OMP_LIST_DEPEND
 			 && n->sym->as
 			 && n->sym->as->type == AS_ASSUMED_SIZE)
 		  gfc_error ("Assumed size array %qs in %s clause at %L",
--- gcc/testsuite/gfortran.dg/gomp/pr80918.f90.jj	2017-05-30 12:12:06.254063046 +0200
+++ gcc/testsuite/gfortran.dg/gomp/pr80918.f90	2017-05-30 12:11:56.000000000 +0200
@@ -0,0 +1,10 @@
+! PR fortran/80918
+! { dg-do compile }
+
+subroutine foo (a)
+  integer :: a(*)
+  !$omp task depend(inout:a)
+  !$omp end task
+  !$omp task depend(inout:a)
+  !$omp end task
+end subroutine foo

	Jakub

                 reply	other threads:[~2017-06-02  7:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170602071046.GL24023@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).