From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13834 invoked by alias); 2 Jun 2017 07:10:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13808 invoked by uid 89); 2 Jun 2017 07:10:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Jun 2017 07:10:47 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 85B85C04B31E for ; Fri, 2 Jun 2017 07:10:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85B85C04B31E Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 85B85C04B31E Received: from tucnak.zalov.cz (unknown [10.36.118.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CD555C549 for ; Fri, 2 Jun 2017 07:10:50 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v527AlVY000911 for ; Fri, 2 Jun 2017 09:10:47 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v527Akv9000909 for gcc-patches@gcc.gnu.org; Fri, 2 Jun 2017 09:10:46 +0200 Date: Fri, 02 Jun 2017 07:10:00 -0000 From: Jakub Jelinek To: gcc-patches@gcc.gnu.org Subject: [committed] Fix typo in Fortran OpenMP handling (PR fortran/80918) Message-ID: <20170602071046.GL24023@tucnak> Reply-To: Jakub Jelinek MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00093.txt.bz2 Hi! When backporting patches to 5.x, I've noticed a typo that causes us to diagnose something that shouldn't be diagnosed. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk and 7.2, queued for 6.x. 2017-06-02 Jakub Jelinek PR fortran/80918 * openmp.c (resolve_omp_clauses): Fix a typo. * gfortran.dg/gomp/pr80918.f90: New test. --- gcc/fortran/openmp.c.jj 2017-05-24 11:59:03.000000000 +0200 +++ gcc/fortran/openmp.c 2017-05-30 11:38:29.905964424 +0200 @@ -4381,7 +4381,7 @@ resolve_omp_clauses (gfc_code *code, gfc else resolve_oacc_data_clauses (n->sym, n->where, name); } - else if (list != OMP_CLAUSE_DEPEND + else if (list != OMP_LIST_DEPEND && n->sym->as && n->sym->as->type == AS_ASSUMED_SIZE) gfc_error ("Assumed size array %qs in %s clause at %L", --- gcc/testsuite/gfortran.dg/gomp/pr80918.f90.jj 2017-05-30 12:12:06.254063046 +0200 +++ gcc/testsuite/gfortran.dg/gomp/pr80918.f90 2017-05-30 12:11:56.000000000 +0200 @@ -0,0 +1,10 @@ +! PR fortran/80918 +! { dg-do compile } + +subroutine foo (a) + integer :: a(*) + !$omp task depend(inout:a) + !$omp end task + !$omp task depend(inout:a) + !$omp end task +end subroutine foo Jakub