public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: James Greenhalgh <james.greenhalgh@arm.com>
Cc: libstdc++@gcc.gnu.org, nd@arm.com, Michael.Collison@arm.com,
	gcc-patches@gcc.gnu.org
Subject: Re: Fw: [PATCH][Aarch64] Add vectorized mersenne twister
Date: Fri, 02 Jun 2017 14:57:00 -0000	[thread overview]
Message-ID: <20170602145719.GA8689@redhat.com> (raw)
In-Reply-To: <20170602142929.GA40346@arm.com>

On 02/06/17 15:29 +0100, James Greenhalgh wrote:
>Hi Michael,
>
>I think the correct list for this patch would be libstdc++@gcc.gnu.org
>(I'm sure someone there will correct me if I'm wrong).

Thanks, James, that's right. All libstdc++ patches should go to both
gcc-patches and this list.


>I'm interested in the answer to your point about polluting the global
>namespace.

It's not ideal, but I agree it's acceptable when including a
non-standard extension header. Strictly conforming programs won't use
that header, and won't get the namespace pollution.

However, if I'm reading the patch correctly it will also happen when
including <random>, because that will use the new
config/cpu/aarch64/opt/bits/opt_random.h header which includes
"arm_neon.h".

That aside, this looks like a nice addition.

The #include "arm_neon.h" directives should use <arm_neon.h> instead.


>	Add optimized implementation of mersenne twister for aarch64
>	* config/cpu/aarch64/opt/ext/opt_random.h: New file.
>	(__arch64_recursion): new function.
>	(operator==): New function.
>	(simd_fast_mersenne_twister_engine): New template class.

This line of the changelog seems unnecessary, no new class template is
being added.

>	* config/cpu/aarch64/opt/bits/opt_random.h: New file.
>	* include/ext/random (add include for arm_neon.h):
>	(simd_fast_mersenne_twister_engine): add _M_state private
>	array for ARM_NEON conditional compilation.

           reply	other threads:[~2017-06-02 14:57 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20170602142929.GA40346@arm.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170602145719.GA8689@redhat.com \
    --to=jwakely@redhat.com \
    --cc=Michael.Collison@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=james.greenhalgh@arm.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).