From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56715 invoked by alias); 2 Jun 2017 14:57:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 55396 invoked by uid 89); 2 Jun 2017 14:57:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1476 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Jun 2017 14:57:17 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3220C334599; Fri, 2 Jun 2017 14:57:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3220C334599 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3220C334599 Received: from localhost (unknown [10.33.36.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4F2977C0D; Fri, 2 Jun 2017 14:57:19 +0000 (UTC) Date: Fri, 02 Jun 2017 14:57:00 -0000 From: Jonathan Wakely To: James Greenhalgh Cc: libstdc++@gcc.gnu.org, nd@arm.com, Michael.Collison@arm.com, gcc-patches@gcc.gnu.org Subject: Re: Fw: [PATCH][Aarch64] Add vectorized mersenne twister Message-ID: <20170602145719.GA8689@redhat.com> References: <20170602142929.GA40346@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170602142929.GA40346@arm.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-06/txt/msg00141.txt.bz2 On 02/06/17 15:29 +0100, James Greenhalgh wrote: >Hi Michael, > >I think the correct list for this patch would be libstdc++@gcc.gnu.org >(I'm sure someone there will correct me if I'm wrong). Thanks, James, that's right. All libstdc++ patches should go to both gcc-patches and this list. >I'm interested in the answer to your point about polluting the global >namespace. It's not ideal, but I agree it's acceptable when including a non-standard extension header. Strictly conforming programs won't use that header, and won't get the namespace pollution. However, if I'm reading the patch correctly it will also happen when including , because that will use the new config/cpu/aarch64/opt/bits/opt_random.h header which includes "arm_neon.h". That aside, this looks like a nice addition. The #include "arm_neon.h" directives should use instead. > Add optimized implementation of mersenne twister for aarch64 > * config/cpu/aarch64/opt/ext/opt_random.h: New file. > (__arch64_recursion): new function. > (operator==): New function. > (simd_fast_mersenne_twister_engine): New template class. This line of the changelog seems unnecessary, no new class template is being added. > * config/cpu/aarch64/opt/bits/opt_random.h: New file. > * include/ext/random (add include for arm_neon.h): > (simd_fast_mersenne_twister_engine): add _M_state private > array for ARM_NEON conditional compilation.