From: James Greenhalgh <james.greenhalgh@arm.com>
To: Sudi Das <Sudi.Das@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
nd <nd@arm.com>, Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][AArch64] Allow CMP+SHIFT when comparing with zero
Date: Fri, 02 Jun 2017 15:33:00 -0000 [thread overview]
Message-ID: <20170602153330.GB40346@arm.com> (raw)
In-Reply-To: <VI1PR08MB0640AE02B80EBC2F697C574398260@VI1PR08MB0640.eurprd08.prod.outlook.com>
On Thu, Mar 16, 2017 at 11:26:27AM +0000, Sudi Das wrote:
> Hi all
>
> The backend pattern for combining a CMP+SHIFT was missing out on a case when comparing with zero. This was happening because aarch64_select_cc_mode (SELECT_CC_MODE) was not returning the correct mode (in this case CC_SWP) which was needed to identify the combine. This patch adds this missing case.
>
> For the test case :
>
>
> int f3 (int x, int y)
> {
> int res = x << 3;
> return res != 0;
> }
>
> We are now generating (at -O2)
>
> f3:
> cmp wzr, w0, lsl 3
> cset w0, ne
> ret
>
> instead of :
>
> f3:
> lsl w0, w0, 3
> cmp w0, 0
> cset w0, ne
> ret
>
>
> Added this new test and checked for regressions on bootstrapped aarch64-none-linux-gnu.
> Ok for stage 1?
This is OK. I've applied it on your behalf as revision 248836.
Thanks,
James
> 2017-03-10 Sudakshina Das <sudi.das@arm.com>
>
> * config/aarch64/aarch64.c (aarch64_select_cc_mode): Return CC_SWP for
> comparision with zero.
>
> 2017-03-10 Sudakshina Das <sudi.das@arm.com>
>
> * gcc.target/aarch64/cmp_shifted_reg_1.c: New Test.
prev parent reply other threads:[~2017-06-02 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 11:26 Sudi Das
2017-06-02 15:33 ` James Greenhalgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602153330.GB40346@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Sudi.Das@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).