public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [rs6000] Fix ICE with -fstack-limit-register and large frames
Date: Fri, 02 Jun 2017 16:25:00 -0000	[thread overview]
Message-ID: <20170602162531.GZ19687@gate.crashing.org> (raw)
In-Reply-To: <41568560.kqil6v8Xzx@polaris>

On Fri, Jun 02, 2017 at 10:27:33AM +0200, Eric Botcazou wrote:
> > Could you make the expander handle it, instead?  It's as simple as (after
> > the double-reg thing) add "if operands[1] is reg 0, force_reg operands[2]".
> > I'll do it if you prefer.
> 
> Probably, because I'm not sure how this can work, as you cannot create new 
> pseudos here.

Because you cannot during reload, or another reason?  We always use LRA
on powerpc nowadays, and LRA can deal with this.

> > [ the patch is broken here ]
> 
> It applies just fine for me though.  But it could probably use add_operand 
> instead of satisfies_constraint_I in the condition.

Only the first hunk (rs6000.md) applies, the rest is ignored (there is a
blank line here instead of a diff header).

add_operand would be better, yeah.

> > > /* { dg-do compile } */
> > > /* { dg-options "-fstack-limit-register=r2" } */
> > 
> > Please use a different register, r2 already has different functions in
> > most ABIs.  It *probably* will compile anyway, but :-)
> 
> It's a straight copy of gcc.target/powerpc/pr48344-1.c though.

I see.  We'll fix it :-)


Segher

  reply	other threads:[~2017-06-02 16:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24  7:53 Eric Botcazou
2017-05-26 13:25 ` Segher Boessenkool
2017-06-02  8:27   ` Eric Botcazou
2017-06-02 16:25     ` Segher Boessenkool [this message]
2017-06-03 10:34       ` Eric Botcazou
2017-06-03 19:56         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170602162531.GZ19687@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).