public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Michael Meissner <meissner@linux.vnet.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Michael Meissner <meissner@linux.vnet.ibm.com>,
	       Florian Weimer <fweimer@gapps.redhat.com>,
	       GCC Patches <gcc-patches@gcc.gnu.org>,
	       David Edelsohn <dje.gcc@gmail.com>,
	       Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH] Add attribute((target_clone(...))) to PowerPC
Date: Fri, 02 Jun 2017 17:39:00 -0000	[thread overview]
Message-ID: <20170602173933.GB29231@ibm-tiger.the-meissners.org> (raw)
In-Reply-To: <20170602165557.GA19687@gate.crashing.org>

On Fri, Jun 02, 2017 at 11:55:57AM -0500, Segher Boessenkool wrote:
> Hi!
> 
> On Fri, Jun 02, 2017 at 10:16:27AM -0400, Michael Meissner wrote:
> > > With "you don't have to give the enum a name" I meant write it as
> > > 
> > > enum {
> > >   CLONE_DEFAULT = 0,
> > >   CLONE_ISA_2_05,
> > > [...]
> > >   CLONE_MASK
> > > };
> > > 
> > > If you do "const int", I think it should be "static const int"?
> > 
> > Ok.  I think I was under the impression that enums were more tightly typed on
> > C++ compared to C, and that you needed explicit casts to/from integer.
> 
> No, conversions from enum to int are still explicitly allowed (but not
> the other way around indeed).
> 
> > > > +#if defined (ASM_OUTPUT_TYPE_DIRECTIVE)
> > > > +  if (targetm.has_ifunc_p ())
> > > 
> > > Hrm, I still don't see what you need the #ifdef for.  What in the
> > > following code won't compile without it?  Or does targetm.has_ifunc_p
> > > return the wrong answer?
> > 
> > Right now, we only enable ifunc by default under Linux, so I removed the
> > #ifdef.  We will see if it breaks on non Linux systems.
> 
> Heh, you could test, you know ;-)

I actually did a bootstrap/make check of everything but the removal of the
#ifdef.  There was one test that had failed with my previous base run that now
runs, but it looks like a filesystem problem with the old base run.

> The patch is okay for trunk, but please test on AIX.

You mentioned in private IRC that you would do the run on AIX, did you want me
to wait until it is finished?

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797

  reply	other threads:[~2017-06-02 17:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 18:54 Michael Meissner
2017-05-25 20:05 ` Florian Weimer
2017-05-25 20:18   ` Michael Meissner
2017-05-30 22:04     ` Segher Boessenkool
2017-05-31  2:22       ` Michael Meissner
2017-05-31 23:15       ` Michael Meissner
2017-06-01  0:20         ` Michael Meissner
2017-06-01 20:43         ` Segher Boessenkool
2017-06-02 14:16           ` Michael Meissner
2017-06-02 16:56             ` Segher Boessenkool
2017-06-02 17:39               ` Michael Meissner [this message]
2017-06-02 17:41                 ` Segher Boessenkool
2017-06-05 21:20                   ` Michael Meissner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170602173933.GB29231@ibm-tiger.the-meissners.org \
    --to=meissner@linux.vnet.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=fweimer@gapps.redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=segher@kernel.crashing.org \
    --cc=wschmidt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).