From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93128 invoked by alias); 5 Jun 2017 16:49:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 92811 invoked by uid 89); 5 Jun 2017 16:49:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:668 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Jun 2017 16:49:45 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A08AF8046E; Mon, 5 Jun 2017 16:49:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A08AF8046E Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A08AF8046E Received: from localhost (unknown [10.33.36.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 547725DD60; Mon, 5 Jun 2017 16:49:48 +0000 (UTC) Date: Mon, 05 Jun 2017 16:49:00 -0000 From: Jonathan Wakely To: Tim Shen Cc: libstdc++ , gcc-patches , Tim Song Subject: Re: [PATCH] PR libstdc++/80939 Remove unmeetable constexpr specifiers Message-ID: <20170605164947.GQ12306@redhat.com> References: <20170602130734.GA6233@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-06/txt/msg00238.txt.bz2 On 02/06/17 12:19 -0700, Tim Shen wrote: >On Fri, Jun 2, 2017 at 6:07 AM, Jonathan Wakely wrote: >> As the PR points out, we aren't qualifying calls to __ref_cast, and >> have 'constexpr' on function templates that can never be usable in >> constant expressions. > >Apology for the constexpr trolling, but that was not intentional. :) > >I'm curious why no tests break. Is it because constexpr in a template >function is a no-op instead of a hard error, when the function >definition is not constexpr? > >The patch looks good. Committed to trunk (I'll backport it to gcc-7-branch some time too).