From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65548 invoked by alias); 6 Jun 2017 08:00:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 65519 invoked by uid 89); 6 Jun 2017 08:00:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Jun 2017 08:00:45 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 643175433C0; Tue, 6 Jun 2017 10:00:47 +0200 (CEST) Date: Tue, 06 Jun 2017 08:00:00 -0000 From: Jan Hubicka To: Jason Merrill Cc: gcc-patches List Subject: Re: Reorgnanization of profile count maintenance code, part 1 Message-ID: <20170606080047.GB95556@kam.mff.cuni.cz> References: <20170601113556.GH22051@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2017-06/txt/msg00267.txt.bz2 > On Thu, Jun 1, 2017 at 4:35 AM, Jan Hubicka wrote: > > Index: profile.c > > =================================================================== > > --- profile.c (revision 248684) > > +++ profile.c (working copy) > > @@ -67,6 +67,10 @@ along with GCC; see the file COPYING3. > > > > #include "profile.h" > > > > +/* Map from BBs/edges to gcov counters. */ > > +vec bb_gcov_counts; > > +hash_map edge_gcov_counts; > > This completely breaks the compiler with > --enable-gather-detailed-mem-stats; edge_gcov_counts gets initialized > before hash_table_usage in hash-table.c, and so when the constructor > for edge_gcov_counts calls hash_table_usage.register_descriptor, m_map > is null and we get a SEGV. I will change this to pointer to avoid static cdtor. Thanks! Honza > > Jason