From: Jan Hubicka <hubicka@ucw.cz>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Statically propagate basic blocks which are likely executed 0 times
Date: Fri, 09 Jun 2017 18:35:00 -0000 [thread overview]
Message-ID: <20170609183514.GA12391@kam.mff.cuni.cz> (raw)
In-Reply-To: <4E3B1900-B7BF-4332-B6E4-25FA4BEC81B8@gmail.com>
Hi,
this is patch I comitted.
Thanks!
Honza
* predict.c (unlikely_executed_stmt_p): Cleanup.
Index: predict.c
===================================================================
--- predict.c (revision 249057)
+++ predict.c (working copy)
@@ -780,7 +780,7 @@ unlikely_executed_stmt_p (gimple *stmt)
{
if (!is_gimple_call (stmt))
return false;
- /* NORETURN attribute enough is not strong enough: exit() may be quite
+ /* NORETURN attribute alone is not strong enough: exit() may be quite
likely executed once during program run. */
if (gimple_call_fntype (stmt)
&& lookup_attribute ("cold",
@@ -797,10 +797,11 @@ unlikely_executed_stmt_p (gimple *stmt)
cgraph_node *n = cgraph_node::get (decl);
if (!n)
return false;
- enum availability avail;
+
+ availability avail;
n = n->ultimate_alias_target (&avail);
if (avail < AVAIL_AVAILABLE)
- return NULL;
+ return false;
if (!n->analyzed
|| n->decl == current_function_decl)
return false;
prev parent reply other threads:[~2017-06-09 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 12:52 Jan Hubicka
2017-06-09 6:43 ` Bernhard Reutner-Fischer
2017-06-09 9:04 ` Christophe Lyon
2017-06-09 9:54 ` Jan Hubicka
2017-06-12 10:19 ` Renlin Li
2017-06-12 10:36 ` Jan Hubicka
2017-06-09 18:35 ` Jan Hubicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609183514.GA12391@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).