public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Renlin Li <renlin.li@foss.arm.com>
Cc: Christophe Lyon <christophe.lyon@linaro.org>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Statically propagate basic blocks which are likely executed 0 times
Date: Mon, 12 Jun 2017 10:36:00 -0000	[thread overview]
Message-ID: <20170612103641.GE9766@kam.mff.cuni.cz> (raw)
In-Reply-To: <593E6AA1.6090900@foss.arm.com>

> Hi Honza & Christophe,
> 
> I have tested your suggested fix. It does fix the regression.
> Here is a simple patch for it.
> 
> After r249013, die () and dump_stack () are both in cold section. This makes
> the compiler generate bl instruction for the function call, instead of
> honoring the -mlong-calls option.
> 
> This patch changes the dump_stack function call conditional, which fixes the
> regression.
> 
> Okay to commit?
> 
> Regards,
> Renlin
> 
> gcc/testsuite/ChangeLog:
> 
> 2017-06-12  Renlin Li  <renlin.li@arm.com>
> 
> 	* gcc.target/arm/cold-lc.c: Update coding style, call dump_stack
> 	conditionally.

Looks OK to me.  I think it does not change purpose of the testcase ;)

Honza

  reply	other threads:[~2017-06-12 10:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 12:52 Jan Hubicka
2017-06-09  6:43 ` Bernhard Reutner-Fischer
2017-06-09  9:04   ` Christophe Lyon
2017-06-09  9:54     ` Jan Hubicka
2017-06-12 10:19       ` Renlin Li
2017-06-12 10:36         ` Jan Hubicka [this message]
2017-06-09 18:35   ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612103641.GE9766@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=christophe.lyon@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=renlin.li@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).