From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-455671-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 82150 invoked by alias); 12 Jun 2017 10:36:42 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 81858 invoked by uid 89); 12 Jun 2017 10:36:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=
X-HELO: nikam.ms.mff.cuni.cz
Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Jun 2017 10:36:40 +0000
Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202)	id 1A4755480D1; Mon, 12 Jun 2017 12:36:41 +0200 (CEST)
Date: Mon, 12 Jun 2017 10:36:00 -0000
From: Jan Hubicka <hubicka@ucw.cz>
To: Renlin Li <renlin.li@foss.arm.com>
Cc: Christophe Lyon <christophe.lyon@linaro.org>,	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Statically propagate basic blocks which are likely executed 0 times
Message-ID: <20170612103641.GE9766@kam.mff.cuni.cz>
References: <20170608125249.GB65161@kam.mff.cuni.cz> <4E3B1900-B7BF-4332-B6E4-25FA4BEC81B8@gmail.com> <CAKdteOboVwYtqCgofsZR85eG17kOeusa+iVzKcg_0TU-piNHjg@mail.gmail.com> <20170609095435.GD6887@kam.mff.cuni.cz> <593E6AA1.6090900@foss.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <593E6AA1.6090900@foss.arm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SW-Source: 2017-06/txt/msg00766.txt.bz2

> Hi Honza & Christophe,
> 
> I have tested your suggested fix. It does fix the regression.
> Here is a simple patch for it.
> 
> After r249013, die () and dump_stack () are both in cold section. This makes
> the compiler generate bl instruction for the function call, instead of
> honoring the -mlong-calls option.
> 
> This patch changes the dump_stack function call conditional, which fixes the
> regression.
> 
> Okay to commit?
> 
> Regards,
> Renlin
> 
> gcc/testsuite/ChangeLog:
> 
> 2017-06-12  Renlin Li  <renlin.li@arm.com>
> 
> 	* gcc.target/arm/cold-lc.c: Update coding style, call dump_stack
> 	conditionally.

Looks OK to me.  I think it does not change purpose of the testcase ;)

Honza