From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36960 invoked by alias); 15 Jun 2017 11:04:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36932 invoked by uid 89); 15 Jun 2017 11:04:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Jun 2017 11:03:59 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 544FA723B6; Thu, 15 Jun 2017 11:04:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 544FA723B6 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 544FA723B6 Received: from localhost (unknown [10.33.36.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 038F07E486; Thu, 15 Jun 2017 11:04:02 +0000 (UTC) Date: Thu, 15 Jun 2017 11:04:00 -0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: Avoid _Rb_tree_rotate_[left,right] symbols export Message-ID: <20170615110402.GM2958@redhat.com> References: <20170512110342.GY5109@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-06/txt/msg01105.txt.bz2 On 13/06/17 21:51 +0200, François Dumont wrote: >On 12/05/2017 13:03, Jonathan Wakely wrote: >>A much simpler (but equivalent) change would be: >> >>--- a/libstdc++-v3/src/c++98/tree.cc >>+++ b/libstdc++-v3/src/c++98/tree.cc >>@@ -153,6 +153,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >> /* Static keyword was missing on _Rb_tree_rotate_left. >> Export the symbol for backward compatibility until >> next ABI change. */ >>+#if _GLIBCXX_INLINE_VERSION >>+ static >>+#endif > >Ok, so it looks like you are not a great fan of the anonymous >namespace in this context. > >Here is a new proposal. We don't need to add static keyword, this >function is only here to be exported for backward compatibility. > >>>Tested under Linux x86_64 with versioned namespace. >> >>What about the normal configuration? It's much more important that the >>default configuration works. The versioned namespace that nobody uses >>doesn't matter. > >Tested under Linux x86_64 normal mode. > >Ok to commit ? OK, thanks.