public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org,
	fortran@gcc.gnu.org,	Uros Bizjak <ubizjak@gmail.com>,
	Jonathan Yong <10walls@gmail.com>,
	Mike Stump <mikestump@comcast.net>
Subject: Re: [testsuite, i386] Always check for target i?86 and x86_64
Date: Thu, 15 Jun 2017 11:31:00 -0000	[thread overview]
Message-ID: <20170615113104.GP2958@redhat.com> (raw)
In-Reply-To: <yddo9tp5xs7.fsf@CeBiTec.Uni-Bielefeld.DE>

On 15/06/17 12:51 +0200, Rainer Orth wrote:
>I happened to notice that recently a couple of testcases have sneaked in
>that are restricted to x86_64-*-* targets only.  This is always wrong:
>it should be i?86-*-* and x86_64-*-* alike, eventually restricing the
>test to ilp32 or lp64.  There were also instances of i?86-*-* only,
>which I've handled as well.

[...]

>diff --git a/libstdc++-v3/testsuite/20_util/variant/index_type.cc b/libstdc++-v3/testsuite/20_util/variant/index_type.cc
>--- a/libstdc++-v3/testsuite/20_util/variant/index_type.cc
>+++ b/libstdc++-v3/testsuite/20_util/variant/index_type.cc
>@@ -1,5 +1,5 @@
> // { dg-options "-std=gnu++17" }
>-// { dg-do compile { target x86_64-*-* powerpc*-*-* } }
>+// { dg-do compile { target i?86-*-* x86_64-*-* powerpc*-*-* } }
> 
> // Copyright (C) 2017 Free Software Foundation, Inc.
> //

The concern here was just that we don't want the test to fail on
targets with weird integer sizes, so the list of targets was
restricted to just those where Ville had tested it.

But { target ilp32 lp64 } would surely be fine. The test will only
fail if a struct with two char-sized subobjects is the same size as
size_t. Feel free to change it to { target ilp32 lp64 }.

  reply	other threads:[~2017-06-15 11:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 10:51 Rainer Orth
2017-06-15 11:31 ` Jonathan Wakely [this message]
2017-06-20 13:01   ` Rainer Orth
2017-06-20 13:25     ` JonY
2017-06-20 13:35       ` Rainer Orth
2017-06-20 14:29         ` JonY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170615113104.GP2958@redhat.com \
    --to=jwakely@redhat.com \
    --cc=10walls@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).