From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124296 invoked by alias); 15 Jun 2017 11:31:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124266 invoked by uid 89); 15 Jun 2017 11:31:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-21.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 3 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Jun 2017 11:31:02 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EBD79128D; Thu, 15 Jun 2017 11:31:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EBD79128D Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EBD79128D Received: from localhost (unknown [10.33.36.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9928487E5C; Thu, 15 Jun 2017 11:31:05 +0000 (UTC) Date: Thu, 15 Jun 2017 11:31:00 -0000 From: Jonathan Wakely To: Rainer Orth Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, fortran@gcc.gnu.org, Uros Bizjak , Jonathan Yong <10walls@gmail.com>, Mike Stump Subject: Re: [testsuite, i386] Always check for target i?86 and x86_64 Message-ID: <20170615113104.GP2958@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-06/txt/msg01108.txt.bz2 On 15/06/17 12:51 +0200, Rainer Orth wrote: >I happened to notice that recently a couple of testcases have sneaked in >that are restricted to x86_64-*-* targets only. This is always wrong: >it should be i?86-*-* and x86_64-*-* alike, eventually restricing the >test to ilp32 or lp64. There were also instances of i?86-*-* only, >which I've handled as well. [...] >diff --git a/libstdc++-v3/testsuite/20_util/variant/index_type.cc b/libstdc++-v3/testsuite/20_util/variant/index_type.cc >--- a/libstdc++-v3/testsuite/20_util/variant/index_type.cc >+++ b/libstdc++-v3/testsuite/20_util/variant/index_type.cc >@@ -1,5 +1,5 @@ > // { dg-options "-std=gnu++17" } >-// { dg-do compile { target x86_64-*-* powerpc*-*-* } } >+// { dg-do compile { target i?86-*-* x86_64-*-* powerpc*-*-* } } > > // Copyright (C) 2017 Free Software Foundation, Inc. > // The concern here was just that we don't want the test to fail on targets with weird integer sizes, so the list of targets was restricted to just those where Ville had tested it. But { target ilp32 lp64 } would surely be fine. The test will only fail if a struct with two char-sized subobjects is the same size as size_t. Feel free to change it to { target ilp32 lp64 }.