public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.vnet.ibm.com>,
	       GCC Patches <gcc-patches@gcc.gnu.org>,
	       David Edelsohn <dje.gcc@gmail.com>,
	       Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH, rev 2] PR target/79799, Add vec_insert of V4SFmode on PowerPC ISA 3.0 (power9)
Date: Mon, 19 Jun 2017 23:16:00 -0000	[thread overview]
Message-ID: <20170619231641.GP16550@gate.crashing.org> (raw)
In-Reply-To: <20170616215534.GA24208@ibm-tiger.the-meissners.org>

On Fri, Jun 16, 2017 at 05:55:35PM -0400, Michael Meissner wrote:
> Here is the latest patch that restricts the optimization to 64-bit (due to
> needing VSX small integers).  I've done a full bootstrap/make check on a little
> endian power8 system, and a build without bootstrap and make check on a little
> endian power9 system.  Neither the power8 nor the power9 systems had any
> regressions.  I'm also running a test on a big endian power7 system for
> completeness.
> 
> Assuming the power7 test finishes without any regressions, can I check this
> patch into the trunk and later the GCC 7 branch.
> 
> The main change was to restrict the optimization to 64-bit PowerPC that have
> VSX small integer support turned on (default for 64-bit).  I did shorten the
> one line in the testsuite that you mentioned.

Okay for both.  Thanks!


Segher


> 2017-06-16  Michael Meissner  <meissner@linux.vnet.ibm.com>
> 
> 	PR target/79799
> 	* config/rs6000/rs6000.c (rs6000_expand_vector_init): Add support
> 	for doing vector set of SFmode on ISA 3.0.
> 	* config/rs6000/vsx.md (vsx_set_v4sf_p9): Likewise.
> 	(vsx_set_v4sf_p9_zero): Special case setting 0.0f to a V4SF
> 	element.
> 	(vsx_insert_extract_v4sf_p9): Add an optimization for inserting a
> 	SFmode value into a V4SF variable that was extracted from another
> 	V4SF variable without converting the element to double precision
> 	and back to single precision vector format.
> 	(vsx_insert_extract_v4sf_p9_2): Likewise.
> 
> [gcc/testsuite]
> 2017-06-16  Michael Meissner  <meissner@linux.vnet.ibm.com>
> 
> 	PR target/79799
> 	* gcc.target/powerpc/pr79799-1.c: New test.
> 	* gcc.target/powerpc/pr79799-2.c: Likewise.
> 	* gcc.target/powerpc/pr79799-3.c: Likewise.
> 	* gcc.target/powerpc/pr79799-4.c: Likewise.
> 	* gcc.target/powerpc/pr79799-5.c: Likewise.

      reply	other threads:[~2017-06-19 23:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15  0:02 [PATCH] " Michael Meissner
2017-06-15 23:39 ` Michael Meissner
2017-06-16  2:10   ` [PATCH, rev 2] " Michael Meissner
2017-06-16 19:52     ` Segher Boessenkool
2017-06-16 20:27       ` Michael Meissner
2017-06-16 21:30         ` Segher Boessenkool
2017-06-16 21:55           ` Michael Meissner
2017-06-19 23:16             ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619231641.GP16550@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=meissner@linux.vnet.ibm.com \
    --cc=wschmidt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).