From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71609 invoked by alias); 19 Jun 2017 23:23:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 71600 invoked by uid 89); 19 Jun 2017 23:23:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=pulling, 50pm, 50PM, love X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jun 2017 23:23:18 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v5JNNJ4Z029368; Mon, 19 Jun 2017 18:23:20 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v5JNNJsU029367; Mon, 19 Jun 2017 18:23:19 -0500 Date: Mon, 19 Jun 2017 23:23:00 -0000 From: Segher Boessenkool To: Carl Love Cc: gcc-patches@gcc.gnu.org, Bill Schmidt , David Edelsohn Subject: Re: [PATCH rs6000] Fix for commit 249311 Message-ID: <20170619232318.GQ16550@gate.crashing.org> References: <1497672530.3876.11.camel@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497672530.3876.11.camel@us.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01389.txt.bz2 On Fri, Jun 16, 2017 at 09:08:50PM -0700, Carl Love wrote: > Commit r249311 had an error. During the patch review the define expand > for VFC_inst was changed to VF_sxddp. I compiled and tested the source > after making the change and it seemed fine. However, I missed a couple > of changes. It seems that since I didn't remove all the binaries before > recompiling the build tree still had the old definition in it. Either we have some missing dependencies then, or (more likely) something in your workflow didn't set modification dates correctly. > I also > found I had to move the VF_sxddp definition back to the file where it is > used. Need to make sure I do a clean build just to be sure before > committing things. > > I found the issue after pulling down a fresh tree and compiling when the > build failed. I have already applied the following change to the tree > as I didn't want to leave a broken tree all weekend. Thanks! > Please let me know > if there are any changes to this fix-up patch that you would like to see > made and I will take care of it. > > Sorry about breaking things. Heh, it happens :-) Segher