* [PATCH, rs6000] Fix for vec_mulo and vec_mule test case
@ 2017-06-22 16:04 Carl Love
2017-06-22 17:21 ` Segher Boessenkool
0 siblings, 1 reply; 2+ messages in thread
From: Carl Love @ 2017-06-22 16:04 UTC (permalink / raw)
To: gcc-patches, David Edelsohn, Segher Boessenkool; +Cc: Bill Schmidt, cel
GCC Maintainers:
Commit 249424 fixed the vec_mulo and vec_mule support however, the
changes for the test case did not get included in the previous patch.
The testing worked great for me as I had the fix. Not so good for
everyone else as I didn't share the test case fix with mainline. Sorry
for the omission in the previous patch.
I have tested the following fix on powerpc64le-unknown-linux-gnu
(Power 8 LE), powerpc64-unknown-linux-gnu(Power 8 BE),
powerpc64-unknown-linux-gnu (Power 7).
Is the fix OK for gcc mainline?
Carl Love
-------------------------------------------------------------------
gcc/testsuite/ChangeLog:
2017-06-23 Carl Love <cel@us.ibm.com>
* gcc.target/powerpc/builtins-3.c (vmulosh, vmulouh, vmulesh,
vmuleuh): Fix scan-assembler-times should check for word not half word
instructions.
---
gcc/testsuite/gcc.target/powerpc/builtins-3.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-3.c b/gcc/testsuite/gcc.target/powerpc/builtins-3.c
index b252488..00fa6ec 100644
--- a/gcc/testsuite/gcc.target/powerpc/builtins-3.c
+++ b/gcc/testsuite/gcc.target/powerpc/builtins-3.c
@@ -207,10 +207,10 @@ test_vul_sldw_vul_vul (vector unsigned long long x,
test_vsll_slo_vsll_vuc 1 vslo
test_vull_slo_vsll_vsc 1 vslo
test_vull_slo_vsll_vuc 1 vslo
- test_vsll_mulo_vsi_vsi 1 vmulosh
- test_vull_mulo_vui_vui 1 vmulouh
- test_vsll_mule_vsi_vsi 1 vmulesh
- test_vull_mule_vui_vui 1 vmuleuh
+ test_vsll_mulo_vsi_vsi 1 vmulosw
+ test_vull_mulo_vui_vui 1 vmulouw
+ test_vsll_mule_vsi_vsi 1 vmulesw
+ test_vull_mule_vui_vui 1 vmuleuw
test_vsc_mulo_vsc_vsc 1 xxsldwi
test_vuc_mulo_vuc_vuc 1 xxsldwi
test_vssi_mulo_vssi_vssi 1 xxsldwi
@@ -236,8 +236,8 @@ test_vul_sldw_vul_vul (vector unsigned long long x,
/* { dg-final { scan-assembler-times "xvnegsp" 1 } } */
/* { dg-final { scan-assembler-times "xvnegdp" 1 } } */
/* { dg-final { scan-assembler-times "vslo" 4 } } */
-/* { dg-final { scan-assembler-times "vmulosh" 1 } } */
-/* { dg-final { scan-assembler-times "vmulouh" 1 } } */
-/* { dg-final { scan-assembler-times "vmulesh" 1 } } */
-/* { dg-final { scan-assembler-times "vmuleuh" 1 } } */
+/* { dg-final { scan-assembler-times "vmulosw" 1 } } */
+/* { dg-final { scan-assembler-times "vmulouw" 1 } } */
+/* { dg-final { scan-assembler-times "vmulesw" 1 } } */
+/* { dg-final { scan-assembler-times "vmuleuw" 1 } } */
/* { dg-final { scan-assembler-times "xxsldwi" 8 } } */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH, rs6000] Fix for vec_mulo and vec_mule test case
2017-06-22 16:04 [PATCH, rs6000] Fix for vec_mulo and vec_mule test case Carl Love
@ 2017-06-22 17:21 ` Segher Boessenkool
0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2017-06-22 17:21 UTC (permalink / raw)
To: Carl Love; +Cc: gcc-patches, David Edelsohn, Bill Schmidt
Hi Carl,
On Thu, Jun 22, 2017 at 09:04:38AM -0700, Carl Love wrote:
> Commit 249424 fixed the vec_mulo and vec_mule support however, the
> changes for the test case did not get included in the previous patch.
> The testing worked great for me as I had the fix. Not so good for
> everyone else as I didn't share the test case fix with mainline. Sorry
> for the omission in the previous patch.
Heh :-)
> I have tested the following fix on powerpc64le-unknown-linux-gnu
> (Power 8 LE), powerpc64-unknown-linux-gnu(Power 8 BE),
> powerpc64-unknown-linux-gnu (Power 7).
>
> Is the fix OK for gcc mainline?
Sure. Thanks!
Segher
> 2017-06-23 Carl Love <cel@us.ibm.com>
>
> * gcc.target/powerpc/builtins-3.c (vmulosh, vmulouh, vmulesh,
> vmuleuh): Fix scan-assembler-times should check for word not half word
> instructions.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-22 17:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 16:04 [PATCH, rs6000] Fix for vec_mulo and vec_mule test case Carl Love
2017-06-22 17:21 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).