From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11778 invoked by alias); 25 Jun 2017 10:02:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11728 invoked by uid 89); 25 Jun 2017 10:02:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=robot, recognise, UD:lug-owl.de, graham X-HELO: lug-owl.de Received: from lug-owl.de (HELO lug-owl.de) (195.71.106.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Jun 2017 10:01:58 +0000 Received: by lug-owl.de (Postfix, from userid 1001) id 3D525F057A; Sun, 25 Jun 2017 12:01:55 +0200 (CEST) Date: Sun, 25 Jun 2017 10:02:00 -0000 From: Jan-Benedict Glaw To: Graham Markall Cc: gcc-patches@gcc.gnu.org, andrew.burgess@embecosm.com, guybe@mellanox.com, noamca@mellanox.com Subject: Re: [BUILDROBOT] error: =?utf-8?Q?format_?= =?utf-8?B?4oCYJWTigJkgZXhwZWN0cyBhcmd1bWVudCBvZiB0eXBlIOKAmGludOKAmSwg?= =?utf-8?Q?but_argument_3_has_type_=E2=80=98long_int=E2=80=99_=28was?= =?utf-8?Q?=3A?= [PATCH] [ARC] Recognise add_n and sub_n in combine again) Message-ID: <20170625100154.GV23846@lug-owl.de> References: <20170512191423.16256-1-graham.markall@embecosm.com> <20170612094039.GH23846@lug-owl.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k8ylJtLa18RSEDYA" Content-Disposition: inline In-Reply-To: <20170612094039.GH23846@lug-owl.de> X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01864.txt.bz2 --k8ylJtLa18RSEDYA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 3145 Hi Graham, On Mon, 2017-06-12 11:40:39 +0200, Jan-Benedict Glaw wr= ote: > On Fri, 2017-05-12 20:14:23 +0100, Graham Markall wrote: > > Since the combine pass canonicalises shift-add insns using plus and > > ashift (as opposed to plus and mult which it previously used to do), it > > no longer creates *add_n or *sub_n insns, as the patterns match plus and > > mult only. The outcome of this is that some opportunities to generate > > add{1,2,3} and sub{1,2,3} instructions are missed. >=20 > [...] > > diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c > > index 91c28e7..42730d5 100644 > > --- a/gcc/config/arc/arc.c > > +++ b/gcc/config/arc/arc.c > > @@ -3483,6 +3483,14 @@ arc_print_operand (FILE *file, rtx x, int code) > >=20=20 > > return; > >=20=20 > > + case 'c': > > + if (GET_CODE (x) =3D=3D CONST_INT) > > + fprintf (file, "%d", INTVAL (x) ); > > + else > > + output_operand_lossage ("invalid operands to %%c code"); > > + > > + return; > > + >=20 >=20 > Build robot found something (see log at > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=3D704773), > seems to be introduced with the above patch fragment: >=20 > g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exc= eptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwr= ite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pe= dantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror = -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos-configlist_mk/gcc= /gcc -I/home/jbglaw/repos-configlist_mk/gcc/gcc/. -I/home/jbglaw/repos-conf= iglist_mk/gcc/gcc/../include -I/home/jbglaw/repos-configlist_mk/gcc/gcc/../= libcpp/include -I/opt/cfarm/mpc/include -I/home/jbglaw/repos-configlist_mk= /gcc/gcc/../libdecnumber -I/home/jbglaw/repos-configlist_mk/gcc/gcc/../libd= ecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos-configlist_mk/gcc/gcc/.= ./libbacktrace -o arc.o -MT arc.o -MMD -MP -MF ./.deps/arc.TPo /home/jbgl= aw/repos-configlist_mk/gcc/gcc/config/arc/arc.c > /home/jbglaw/repos-configlist_mk/gcc/gcc/config/arc/arc.c: In function = =E2=80=98void arc_print_operand(FILE*, rtx, int)=E2=80=99: > /home/jbglaw/repos-configlist_mk/gcc/gcc/config/arc/arc.c:3503:41: error:= format =E2=80=98%d=E2=80=99 expects argument of type =E2=80=98int=E2=80=99= , but argument 3 has type =E2=80=98long int=E2=80=99 [-Werror=3Dformat=3D] > fprintf (file, "%d", INTVAL (x) ); > ^ > cc1plus: all warnings being treated as errors This still doesn't build, see the two most current builds at http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=3D705416 (arc-elf32, --with-cpu=3Darc600) and http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=3D705415 (arceb-linux-uclibc, --with-cpu=3Darc700). MfG, JBG --=20 Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: The course of history shows that as a government grows, libe= rty the second : decreases." (Thomas Jefferson) --k8ylJtLa18RSEDYA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 181 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAllPihIACgkQHb1edYOZ4bvrqACeNQf0F9v66f9rkvrVurKB1uGh 5D8AoIIcqagX7L6fQfiUrg+LU4dtjEps =OQXI -----END PGP SIGNATURE----- --k8ylJtLa18RSEDYA--