From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79498 invoked by alias); 27 Jun 2017 11:21:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79481 invoked by uid 89); 27 Jun 2017 11:21:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=19pm, 19PM, secure X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 11:21:00 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0F368E771; Tue, 27 Jun 2017 11:20:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F0F368E771 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F0F368E771 Received: from tucnak.zalov.cz (ovpn-116-143.ams2.redhat.com [10.36.116.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D4167BB1A; Tue, 27 Jun 2017 11:20:58 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v5RBKtvx027372; Tue, 27 Jun 2017 13:20:55 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v5RBKr6x027371; Tue, 27 Jun 2017 13:20:53 +0200 Date: Tue, 27 Jun 2017 11:21:00 -0000 From: Jakub Jelinek To: Tom de Vries Cc: Joseph Myers , GCC Patches , Thomas Schwinge Subject: Re: [PATCH] Use secure_getenv for GOMP_DEBUG Message-ID: <20170627112053.GT2123@tucnak> Reply-To: Jakub Jelinek References: <2413b0f6-9cb2-243f-d805-08323a9c9a0a@mentor.com> <1de94c83-96da-f380-9964-1472f63270c9@mentor.com> <20170626152911.GK2123@tucnak> <9110a6a9-43dc-52ca-aabf-20c73ac73775@mentor.com> <20170627073805.GP2123@tucnak> <46104e74-3bac-13b1-54ca-025eb5c48920@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46104e74-3bac-13b1-54ca-025eb5c48920@mentor.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg02011.txt.bz2 On Tue, Jun 27, 2017 at 01:10:19PM +0200, Tom de Vries wrote: > +/* Secure getenv() which returns NULL if running as SUID/SGID. */ > +#ifndef HAVE_SECURE_GETENV > +#if defined (HAVE_UNISTD_H) && defined(HAVE_GETUID) && defined(HAVE_GETEUID) \ > + && defined(HAVE_GETGID) && defined(HAVE_GETEGID) Can you please us consistent formatting (i.e. space between defined and ( everywhere in the patch)? The above line will be too long, so you'll need to split it into 3 lines. Ok with that change, thanks. Jakub