From: Segher Boessenkool <segher@kernel.crashing.org>
To: Carl Love <cel@us.ibm.com>
Cc: gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH, rs6000] Signed builtin support
Date: Wed, 28 Jun 2017 22:05:00 -0000 [thread overview]
Message-ID: <20170628214809.GI16550@gate.crashing.org> (raw)
In-Reply-To: <1498664255.7044.4.camel@us.ibm.com>
Hi Carl,
On Wed, Jun 28, 2017 at 08:37:35AM -0700, Carl Love wrote:
> The following patch adds support for the vec_signed, vec_signede,
> vec_signedo and vec_signed2 builtins.
Are those names ABI-dictated?
> * config/rs6000/vsx.md (UNSPEC_VSX_XVCVSPSXWS, UNSPEC_VSX_XVCVSPSXDS,
> UNSPEC_VSX_VSIGNED2): Add UNSPECS
Missing "."
> * gcc.target/powerpc/builtins-3-runnable.c(test_int_result,
> test_unsigned_int_result, test_ll_int_result,
> test_ll_unsigned_int_result): Add result checking functions, add
> debug support.
Space before "(".
> (main): Add builtin function tests, .
Something is missing here?
> Signed-off-by: Carl Love <carll@us.ibm.com>
We don't use those.
> +(define_expand "vunsignede_v2df"
> + /* Little endian word numbering for operand is 3 2 1 0.
> + take (operand[1] operand[1]) and shift left three words
> + 0 1 2 3 0 1 2 3 => 3 0 1 2
> + Words 0 and 2 are now where they need to be for the result. */
Should use tabs for eight leading spaces.
Okay for trunk with those nits fixed. Thanks!
Segher
next prev parent reply other threads:[~2017-06-28 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 15:37 Carl Love
2017-06-28 22:05 ` Segher Boessenkool [this message]
2017-06-29 12:59 ` Bill Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628214809.GI16550@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=cel@us.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).