From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52671 invoked by alias); 28 Jun 2017 22:05:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 52642 invoked by uid 89); 28 Jun 2017 22:05:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=35AM, 35am, Hx-languages-length:1079, love X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 22:05:01 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQL4w-0001dF-OQ for gcc-patches@gcc.gnu.org; Wed, 28 Jun 2017 18:04:59 -0400 Received: from gate.crashing.org ([63.228.1.57]:41842) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dQL4w-0001cS-8V for gcc-patches@gcc.gnu.org; Wed, 28 Jun 2017 18:04:54 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v5SLmCxt021338; Wed, 28 Jun 2017 16:48:13 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v5SLmAiW021335; Wed, 28 Jun 2017 16:48:10 -0500 Date: Wed, 28 Jun 2017 22:05:00 -0000 From: Segher Boessenkool To: Carl Love Cc: gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt Subject: Re: [PATCH, rs6000] Signed builtin support Message-ID: <20170628214809.GI16550@gate.crashing.org> References: <1498664255.7044.4.camel@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498664255.7044.4.camel@us.ibm.com> User-Agent: Mutt/1.4.2.3i X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 63.228.1.57 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg02216.txt.bz2 Hi Carl, On Wed, Jun 28, 2017 at 08:37:35AM -0700, Carl Love wrote: > The following patch adds support for the vec_signed, vec_signede, > vec_signedo and vec_signed2 builtins. Are those names ABI-dictated? > * config/rs6000/vsx.md (UNSPEC_VSX_XVCVSPSXWS, UNSPEC_VSX_XVCVSPSXDS, > UNSPEC_VSX_VSIGNED2): Add UNSPECS Missing "." > * gcc.target/powerpc/builtins-3-runnable.c(test_int_result, > test_unsigned_int_result, test_ll_int_result, > test_ll_unsigned_int_result): Add result checking functions, add > debug support. Space before "(". > (main): Add builtin function tests, . Something is missing here? > Signed-off-by: Carl Love We don't use those. > +(define_expand "vunsignede_v2df" > + /* Little endian word numbering for operand is 3 2 1 0. > + take (operand[1] operand[1]) and shift left three words > + 0 1 2 3 0 1 2 3 => 3 0 1 2 > + Words 0 and 2 are now where they need to be for the result. */ Should use tabs for eight leading spaces. Okay for trunk with those nits fixed. Thanks! Segher