* [PATCH] Use a specfile that actually allows building programs on NetBSD
@ 2017-06-29 15:51 coypu
2017-06-29 16:05 ` Joseph Myers
2017-06-29 23:23 ` Jeff Law
0 siblings, 2 replies; 4+ messages in thread
From: coypu @ 2017-06-29 15:51 UTC (permalink / raw)
To: gcc-patches; +Cc: coypu
I was thinking of holding a party for the upcoming one year anniversary
of pinging this patch, that was committed to NetBSD's copy of GCC about
a decade ago. without it, I can't compile simple programs.
---
gcc/config/netbsd.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gcc/config/netbsd.h b/gcc/config/netbsd.h
index 4001f240d..f4ac23a73 100644
--- a/gcc/config/netbsd.h
+++ b/gcc/config/netbsd.h
@@ -96,6 +96,7 @@ along with GCC; see the file COPYING3. If not see
%{!pg:-lposix}} \
%{p:-lposix_p} \
%{pg:-lposix_p}} \
+ %{shared:-lc} \
%{!shared: \
%{!symbolic: \
%{!p: \
@@ -109,6 +110,7 @@ along with GCC; see the file COPYING3. If not see
%{!pg:-lposix}} \
%{p:-lposix_p} \
%{pg:-lposix_p}} \
+ %{shared:-lc} \
%{!shared: \
%{!symbolic: \
%{!p: \
--
2.13.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Use a specfile that actually allows building programs on NetBSD
2017-06-29 15:51 [PATCH] Use a specfile that actually allows building programs on NetBSD coypu
@ 2017-06-29 16:05 ` Joseph Myers
2017-06-29 23:23 ` Jeff Law
1 sibling, 0 replies; 4+ messages in thread
From: Joseph Myers @ 2017-06-29 16:05 UTC (permalink / raw)
To: coypu; +Cc: gcc-patches
On Thu, 29 Jun 2017, coypu wrote:
> I was thinking of holding a party for the upcoming one year anniversary
> of pinging this patch, that was committed to NetBSD's copy of GCC about
> a decade ago. without it, I can't compile simple programs.
I advise CC:ing the listed NetBSD maintainers (Jason Thorpe and Krister
Walfridsson) on any ping of a NetBSD GCC patch.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Use a specfile that actually allows building programs on NetBSD
2017-06-29 15:51 [PATCH] Use a specfile that actually allows building programs on NetBSD coypu
2017-06-29 16:05 ` Joseph Myers
@ 2017-06-29 23:23 ` Jeff Law
2017-06-29 23:49 ` coypu
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Law @ 2017-06-29 23:23 UTC (permalink / raw)
To: coypu, gcc-patches
On 06/29/2017 09:51 AM, coypu wrote:
> I was thinking of holding a party for the upcoming one year anniversary
> of pinging this patch, that was committed to NetBSD's copy of GCC about
> a decade ago. without it, I can't compile simple programs.
When it was committed to NetBSD isn't at all relevant. We don't scour
downstream uses for patches that might be useful and since few, if any,
of the most active GCC developers use NetBSD we're unlikely to trip over
the problem ourselves. That makes us reliant upon others to report bugs
and sometimes to even provide patches to fix platform specific issues.
Krister indicated back when you first posted the patch in Jan that he
was going to fix this and other issues in specs handling, but I don't
see that Krister ever followed up.
I wouldn't at all be surprised if this needs further work for pthreads.
But I'll have to leave investigation there to folks that use NetBSD.
I've installed your patch on the trunk.
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Use a specfile that actually allows building programs on NetBSD
2017-06-29 23:23 ` Jeff Law
@ 2017-06-29 23:49 ` coypu
0 siblings, 0 replies; 4+ messages in thread
From: coypu @ 2017-06-29 23:49 UTC (permalink / raw)
To: Jeff Law; +Cc: gcc-patches
On Thu, Jun 29, 2017 at 05:23:37PM -0600, Jeff Law wrote:
> On 06/29/2017 09:51 AM, coypu wrote:
> > I was thinking of holding a party for the upcoming one year anniversary
> > of pinging this patch, that was committed to NetBSD's copy of GCC about
> > a decade ago. without it, I can't compile simple programs.
> When it was committed to NetBSD isn't at all relevant. We don't scour
> downstream uses for patches that might be useful and since few, if any,
> of the most active GCC developers use NetBSD we're unlikely to trip over
> the problem ourselves. That makes us reliant upon others to report bugs
> and sometimes to even provide patches to fix platform specific issues.
>
> Krister indicated back when you first posted the patch in Jan that he
> was going to fix this and other issues in specs handling, but I don't
> see that Krister ever followed up.
>
> I wouldn't at all be surprised if this needs further work for pthreads.
> But I'll have to leave investigation there to folks that use NetBSD.
>
> I've installed your patch on the trunk.
Thank you.
I've spoken with Krister and he is responsive and still interested in
cleaning everything up, but it's good to have things working until then.
I've mentioned it as I'd like to close N many years of not upstreaming
patches :-) sometimes we have good changes, too, but they'll be mostly
netbsd ones.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-29 23:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 15:51 [PATCH] Use a specfile that actually allows building programs on NetBSD coypu
2017-06-29 16:05 ` Joseph Myers
2017-06-29 23:23 ` Jeff Law
2017-06-29 23:49 ` coypu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).