* [PATCH,rs6000] PR80103: Fix typo in test case
@ 2017-06-30 15:56 Kelvin Nilsen
2017-06-30 16:08 ` Peter Bergner
2017-06-30 23:35 ` Segher Boessenkool
0 siblings, 2 replies; 3+ messages in thread
From: Kelvin Nilsen @ 2017-06-30 15:56 UTC (permalink / raw)
To: gcc-patches; +Cc: Segher Boessenkool
While reviewing regression test results for a back port of the PR80103
patch, I discovered a typographic error in the test case. This patch
corrects the error.
I have tested this fix on powerpc64le-unknown-linux-gnu with no
regressions. Is this ok for trunk?
gcc/testsuite/ChangeLog:
2017-06-30 Kelvin Nilsen <kelvin@gcc.gnu.org>
PR target/80103
* gcc.target/powerpc/pr80103-1.c (b): Correct spelling of
__attribute__.
Index: gcc/testsuite/gcc.target/powerpc/pr80103-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/pr80103-1.c (revision 249798)
+++ gcc/testsuite/gcc.target/powerpc/pr80103-1.c (working copy)
@@ -12,5 +12,5 @@
int a;
void b (__attribute__ ((__vector_size__ (16))) char c)
{
- a = ((__attributes__ ((__vector_size__ (2 * sizeof (long)))) long) c)[0];
+ a = ((__attribute__ ((__vector_size__ (2 * sizeof (long)))) long) c)[0];
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH,rs6000] PR80103: Fix typo in test case
2017-06-30 15:56 [PATCH,rs6000] PR80103: Fix typo in test case Kelvin Nilsen
@ 2017-06-30 16:08 ` Peter Bergner
2017-06-30 23:35 ` Segher Boessenkool
1 sibling, 0 replies; 3+ messages in thread
From: Peter Bergner @ 2017-06-30 16:08 UTC (permalink / raw)
To: Kelvin Nilsen, gcc-patches; +Cc: Segher Boessenkool
On 6/30/17 10:56 AM, Kelvin Nilsen wrote:
> While reviewing regression test results for a back port of the PR80103
> patch, I discovered a typographic error in the test case. This patch
> corrects the error.
>
> I have tested this fix on powerpc64le-unknown-linux-gnu with no
> regressions. Is this ok for trunk?
This falls under the "obvious" rule. Go ahead.
Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH,rs6000] PR80103: Fix typo in test case
2017-06-30 15:56 [PATCH,rs6000] PR80103: Fix typo in test case Kelvin Nilsen
2017-06-30 16:08 ` Peter Bergner
@ 2017-06-30 23:35 ` Segher Boessenkool
1 sibling, 0 replies; 3+ messages in thread
From: Segher Boessenkool @ 2017-06-30 23:35 UTC (permalink / raw)
To: Kelvin Nilsen; +Cc: gcc-patches
On Fri, Jun 30, 2017 at 09:56:03AM -0600, Kelvin Nilsen wrote:
>
> While reviewing regression test results for a back port of the PR80103
> patch, I discovered a typographic error in the test case. This patch
> corrects the error.
A syntax error, even... I wonder why we haven't noticed that before.
It won't compile as-is afaics?
> --- gcc/testsuite/gcc.target/powerpc/pr80103-1.c (revision 249798)
> +++ gcc/testsuite/gcc.target/powerpc/pr80103-1.c (working copy)
> @@ -12,5 +12,5 @@
> int a;
> void b (__attribute__ ((__vector_size__ (16))) char c)
> {
> - a = ((__attributes__ ((__vector_size__ (2 * sizeof (long)))) long) c)[0];
> + a = ((__attribute__ ((__vector_size__ (2 * sizeof (long)))) long) c)[0];
> }
Segher
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-30 23:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 15:56 [PATCH,rs6000] PR80103: Fix typo in test case Kelvin Nilsen
2017-06-30 16:08 ` Peter Bergner
2017-06-30 23:35 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).