From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
Cc: gcc-patches@gcc.gnu.org, Francois.Bedard@synopsys.com
Subject: Re: [PATCH 6/7] [ARC] Deprecate mexpand-adddi option.
Date: Thu, 13 Jul 2017 13:18:00 -0000 [thread overview]
Message-ID: <20170713131803.GF27353@embecosm.com> (raw)
In-Reply-To: <1496324097-21221-7-git-send-email-claziss@synopsys.com>
* Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com> [2017-06-01 15:34:56 +0200]:
> From: claziss <claziss@synopsys.com>
>
> Emitting subregs in the expand is not a good idea. Deprecate this
> option.
>
> gcc/
> 2017-04-26 Claudiu Zissulescu <claziss@synopsys.com>
>
> * config/arc/arc.md (adddi3): Remove support for mexpand-adddi
> option.
> (subdi3): Likewise.
> * config/arc/arc.opt (mexpand-adddi): Deprecate it.
> * doc/invoke.texi (mexpand-adddi): Update text.
This looks fine, though the commit message tells me it's not a good
idea, but it would be nice to know _why_ it's not good. Might be nice
to know for future reference.
Also, there's no test. Was there an issue that revealed this as not a
good idea? Could that become a test?
Thanks,
Andrew
> ---
> gcc/config/arc/arc.md | 39 +--------------------------------------
> gcc/config/arc/arc.opt | 2 +-
> gcc/doc/invoke.texi | 2 +-
> 3 files changed, 3 insertions(+), 40 deletions(-)
>
> diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md
> index 928feb1..f595da7 100644
> --- a/gcc/config/arc/arc.md
> +++ b/gcc/config/arc/arc.md
> @@ -2649,30 +2649,7 @@
> (match_operand:DI 2 "nonmemory_operand" "")))
> (clobber (reg:CC CC_REG))])]
> ""
> -{
> - if (TARGET_EXPAND_ADDDI)
> - {
> - rtx l0 = gen_lowpart (SImode, operands[0]);
> - rtx h0 = disi_highpart (operands[0]);
> - rtx l1 = gen_lowpart (SImode, operands[1]);
> - rtx h1 = disi_highpart (operands[1]);
> - rtx l2 = gen_lowpart (SImode, operands[2]);
> - rtx h2 = disi_highpart (operands[2]);
> - rtx cc_c = gen_rtx_REG (CC_Cmode, CC_REG);
> -
> - if (CONST_INT_P (h2) && INTVAL (h2) < 0 && SIGNED_INT12 (INTVAL (h2)))
> - {
> - emit_insn (gen_sub_f (l0, l1, gen_int_mode (-INTVAL (l2), SImode)));
> - emit_insn (gen_sbc (h0, h1,
> - gen_int_mode (-INTVAL (h2) - (l1 != 0), SImode),
> - cc_c));
> - DONE;
> - }
> - emit_insn (gen_add_f (l0, l1, l2));
> - emit_insn (gen_adc (h0, h1, h2));
> - DONE;
> - }
> -})
> +{})
>
> ; This assumes that there can be no strictly partial overlap between
> ; operands[1] and operands[2].
> @@ -2911,20 +2888,6 @@
> {
> if (!register_operand (operands[2], DImode))
> operands[1] = force_reg (DImode, operands[1]);
> - if (TARGET_EXPAND_ADDDI)
> - {
> - rtx l0 = gen_lowpart (SImode, operands[0]);
> - rtx h0 = disi_highpart (operands[0]);
> - rtx l1 = gen_lowpart (SImode, operands[1]);
> - rtx h1 = disi_highpart (operands[1]);
> - rtx l2 = gen_lowpart (SImode, operands[2]);
> - rtx h2 = disi_highpart (operands[2]);
> - rtx cc_c = gen_rtx_REG (CC_Cmode, CC_REG);
> -
> - emit_insn (gen_sub_f (l0, l1, l2));
> - emit_insn (gen_sbc (h0, h1, h2, cc_c));
> - DONE;
> - }
> })
>
> (define_insn_and_split "subdi3_i"
> diff --git a/gcc/config/arc/arc.opt b/gcc/config/arc/arc.opt
> index ed2b827..ad2df26 100644
> --- a/gcc/config/arc/arc.opt
> +++ b/gcc/config/arc/arc.opt
> @@ -328,7 +328,7 @@ Target Var(TARGET_Q_CLASS)
> Enable 'q' instruction alternatives.
>
> mexpand-adddi
> -Target Var(TARGET_EXPAND_ADDDI)
> +Target Warn(%qs is deprecated)
> Expand adddi3 and subdi3 at rtl generation time into add.f / adc etc.
>
>
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 59563aa..b6cf4ce 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -14823,7 +14823,7 @@ Enable pre-reload use of the @code{cbranchsi} pattern.
> @item -mexpand-adddi
> @opindex mexpand-adddi
> Expand @code{adddi3} and @code{subdi3} at RTL generation time into
> -@code{add.f}, @code{adc} etc.
> +@code{add.f}, @code{adc} etc. This option is deprecated.
>
> @item -mindexed-loads
> @opindex mindexed-loads
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-07-13 13:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 13:37 [PATCH 0/7] [ARC] Bug fixing, add support for naked functions Claudiu Zissulescu
2017-06-01 13:37 ` [PATCH 4/7] [ARC] [LRA] Avoid emitting COND_EXEC during expand Claudiu Zissulescu
2017-07-13 11:38 ` Andrew Burgess
2017-07-13 12:54 ` Claudiu Zissulescu
2017-07-17 13:02 ` Claudiu Zissulescu
2017-06-01 13:37 ` [PATCH 3/7] [ARC] [LRA] Fix tests asm constraints Claudiu Zissulescu
2017-06-16 19:37 ` Andrew Burgess
2017-07-10 13:56 ` Claudiu Zissulescu
2017-06-01 13:37 ` [PATCH 2/7] [ARC] Define ADDITIONAL_REGISTER_NAMES Claudiu Zissulescu
2017-06-16 19:37 ` Andrew Burgess
2017-07-10 13:57 ` Claudiu Zissulescu
2017-06-01 13:38 ` [PATCH 5/7] [ARC] Enable indexed loads for elf targers Claudiu Zissulescu
2017-07-13 11:55 ` Andrew Burgess
2017-07-13 13:08 ` Claudiu Zissulescu
2017-07-17 12:33 ` Claudiu Zissulescu
2017-06-01 13:38 ` [PATCH 6/7] [ARC] Deprecate mexpand-adddi option Claudiu Zissulescu
2017-07-13 13:18 ` Andrew Burgess [this message]
2017-07-13 13:31 ` Claudiu Zissulescu
2017-07-17 13:01 ` Claudiu Zissulescu
2017-06-01 13:38 ` [PATCH 1/7] [ARC] Add support for naked functions Claudiu Zissulescu
2017-06-16 19:36 ` Andrew Burgess
2017-06-19 9:55 ` [PATCH][ARC] " Claudiu Zissulescu
2017-07-13 11:21 ` Andrew Burgess
2017-07-17 10:47 ` Claudiu Zissulescu
2017-06-01 13:38 ` [PATCH 7/7] [ARC] Consolidate PIC implementation Claudiu Zissulescu
2017-07-13 13:31 ` Andrew Burgess
2017-07-17 11:05 ` Claudiu Zissulescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713131803.GF27353@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).