From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36986 invoked by alias); 18 Jul 2017 10:33:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36971 invoked by uid 89); 18 Jul 2017 10:33:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail.ud10.udmedia.de Received: from ud10.udmedia.de (HELO mail.ud10.udmedia.de) (194.117.254.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jul 2017 10:33:10 +0000 Received: (qmail 23472 invoked from network); 18 Jul 2017 12:33:04 +0200 Received: from ip5b405f78.dynamic.kabel-deutschland.de (HELO x4) (ud10?360p3@91.64.95.120) by mail.ud10.udmedia.de with ESMTPSA (ECDHE-RSA-AES256-SHA encrypted, authenticated); 18 Jul 2017 12:33:04 +0200 Date: Tue, 18 Jul 2017 10:33:00 -0000 From: Markus Trippelsdorf To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org Subject: Re: Fix ICE in estimate_bb_frequencies Message-ID: <20170718103304.GA283@x4> References: <20170718075420.GA38394@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170718075420.GA38394@kam.mff.cuni.cz> X-SW-Source: 2017-07/txt/msg01047.txt.bz2 On 2017.07.18 at 09:54 +0200, Jan Hubicka wrote: > Hi, > this patch fixes ICE in estimate_bb_frequencies which triggers because we forget > to compute probability for blocks whose count is earlier statically determined to be > 0. > > Bootstrapped/regtested x86_64-linux, will commit it shortly. It also fixes both testcases from PR81318. However the following testcase still ICEs: trippels@gcc2-power8 linux % cat main.i int a; extern void fn4(); __attribute__((__cold__)) void fn1(); void fn2() { fn1(); } void fn3() { fn2(); if (a) fn4(); } trippels@gcc2-power8 linux % gcc -O2 -c main.i during GIMPLE pass: profile_estimate main.i: In function ‘fn3’: main.i:9:1: internal compiler error: in to_reg_br_prob_base, at profile-count.h:189 -- Markus