From: Jonathan Wakely <jwakely@redhat.com>
To: John Marino <gnugcc@marino.st>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>
Subject: Re: [patch] Fix Unwind support on DragonFly BSD after sigtramp move
Date: Wed, 19 Jul 2017 15:56:00 -0000 [thread overview]
Message-ID: <20170719155610.GA10710@redhat.com> (raw)
In-Reply-To: <0f51241f-a372-b119-5d06-ced0ab8c07f9@redhat.com>
On 18/07/17 23:50 -0600, Jeff Law wrote:
>On 07/07/2017 05:17 PM, John Marino wrote:
>> Right after DragonFly 4.8 was released (27 Mar 2017), the signal
>> trampoline was moved (twice) in response to a Ryzen bug. This broke
>> GCC's unwind support for DragonFly.
>>
>> To avoid hardcoding the sigtramp location to avoid issues like this in
>> the future, a new sysctl was added to DragonFly to return the signal
>> trampoline address range (FreeBSD has a similar sysctl for similar
>> reasons). The attached patch fixes DragonFly unwind support for current
>> DragonFly, and maintains support for Release 4.8 and earlier.
>>
>> This patch has been in use for a few months and works fine. It is
>> similar in function to the FreeBSD Aarch64 unwind support I submitted
>> through Andreas T. a few months ago.
>>
>> I believe the patch can be applied to trunk and release 7 branch.
>> I am the closest thing to a maintainer for DragonFly, so I don't know if
>> additional approval is needed. This patch is purely DragonFly-specific
>> and cannot affect other platforms in any way.
>>
>> If agreed, it would be great if somebody could commit this for me
>> against the trunk and GCC-7-branch.
>>
>> Thanks!
>> John
>>
>> P.S. Yes, my copyright assignment is on file (I've contributed a few
>> patches already).
>>
>> suggested log entry of libgcc/ChangeLog:
>>
>> 2017-07-XX John Marino <gnugcc@marino.st>
>> * config/i386/dragonfly-unwind.h: Handle sigtramp relocation.
>
>This is fine. Sorry it's taken so long for me to get to this.
John, I've committed this for you, but didn't test on DragonFly, so
please check it.
prev parent reply other threads:[~2017-07-19 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 23:17 John Marino
2017-07-19 5:50 ` Jeff Law
2017-07-19 15:56 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719155610.GA10710@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnugcc@marino.st \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).