public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Re: [PATCH, rs6000] vec_mule and vec_mulo builtin fix
       [not found] <1500591361.19855.44.camel@us.ibm.com>
@ 2017-07-21 20:43 ` Segher Boessenkool
  2017-07-21 21:15 ` Segher Boessenkool
  1 sibling, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2017-07-21 20:43 UTC (permalink / raw)
  To: Carl Love; +Cc: gcc-patches, David Edelsohn, Bill Schmidt

On Thu, Jul 20, 2017 at 03:56:01PM -0700, Carl Love wrote:
> The following patch is a reworked patch to fix the bugs in the vec_mule
> and vec_mulo patch that had to be reverted.  The reverted fix, added the
> correct mule and mulo instructions with vectorization.  The
> vectorization support resulted in vectorization in several testcases to
> fail.  This patch adds the correct instructions for the vec_mule and
> vec_mulo builtins without vectorization.  The goal is add the
> vectorization support again in a future patch.

The patch looks fine to me, but so did the previous version...  What
has changed?  It's not clear to me.


Segher

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, rs6000] vec_mule and vec_mulo builtin fix
       [not found] <1500591361.19855.44.camel@us.ibm.com>
  2017-07-21 20:43 ` [PATCH, rs6000] vec_mule and vec_mulo builtin fix Segher Boessenkool
@ 2017-07-21 21:15 ` Segher Boessenkool
  1 sibling, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2017-07-21 21:15 UTC (permalink / raw)
  To: Carl Love; +Cc: gcc-patches, David Edelsohn, Bill Schmidt

On Thu, Jul 20, 2017 at 03:56:01PM -0700, Carl Love wrote:
> The following patch is a reworked patch to fix the bugs in the vec_mule
> and vec_mulo patch that had to be reverted.  The reverted fix, added the
> correct mule and mulo instructions with vectorization.  The
> vectorization support resulted in vectorization in several testcases to
> fail.  This patch adds the correct instructions for the vec_mule and
> vec_mulo builtins without vectorization.  The goal is add the
> vectorization support again in a future patch.

Ah, as you explained offline, you removed vec_widen_umult_even_v4si and
friends.  Okay :-)

The patch is okay for trunk then.  Thanks!


Segher

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-21 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1500591361.19855.44.camel@us.ibm.com>
2017-07-21 20:43 ` [PATCH, rs6000] vec_mule and vec_mulo builtin fix Segher Boessenkool
2017-07-21 21:15 ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).