From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1462 invoked by alias); 22 Jul 2017 21:02:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1450 invoked by uid 89); 22 Jul 2017 21:02:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=gcc112, 44AM, 44am X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Jul 2017 21:02:49 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v6ML2jvT022139; Sat, 22 Jul 2017 16:02:46 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v6ML2jl9022138; Sat, 22 Jul 2017 16:02:45 -0500 Date: Sat, 22 Jul 2017 21:02:00 -0000 From: Segher Boessenkool To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org Subject: Re: [00/77] Add wrapper classes for machine_modes Message-ID: <20170722210245.GP13471@gate.crashing.org> References: <8760ewohsv.fsf@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8760ewohsv.fsf@linaro.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg01366.txt.bz2 Hi Richard, On Thu, Jul 13, 2017 at 09:35:44AM +0100, Richard Sandiford wrote: > This series is an update of: > > https://gcc.gnu.org/ml/gcc-patches/2016-12/msg00766.html > > It adds a group of wrapper classes around machine_mode for modes that > are known to belong to, or need to belong to, a particular mode_class. > For example, it adds a scalar_int_mode wrapper for MODE_INT and > MODE_PARTIAL_INT modes, a scalar_float_mode wrapper for MODE_FLOAT and > MODE_DECIMAL_FLOAT modes, and so on. So what does it change in the interfaces we use? I couldn't find an update of documentation, maybe I missed it (it's a huge series :-) ) An overview of the new interfaces (and how they are used) would help. >From what I can tell so far it makes things much harder to read. Perhaps that is just because this is all new. > I tested this by compiling the testsuite for: > > aarch64-linux-gnu alpha-linux-gnu arc-elf arm-linux-gnueabi > arm-linux-gnueabihf avr-elf bfin-elf c6x-elf cr16-elf cris-elf > epiphany-elf fr30-elf frv-linux-gnu ft32-elf h8300-elf > hppa64-hp-hpux11.23 ia64-linux-gnu i686-pc-linux-gnu > i686-apple-darwin iq2000-elf lm32-elf m32c-elf m32r-elf > m68k-linux-gnu mcore-elf microblaze-elf mips-linux-gnu > mipsisa64-linux-gnu mmix mn10300-elf moxie-rtems msp430-elf > nds32le-elf nios2-linux-gnu nvptx-none pdp11 powerpc-linux-gnuspe > powerpc-eabispe powerpc64-linux-gnu powerpc-ibm-aix7.0 riscv64-elf > rl78-elf rx-elf s390-linux-gnu s390x-linux-gnu sh-linux-gnu > sparc-linux-gnu sparc64-linux-gnu sparc-wrs-vxworks spu-elf > tilegx-elf tilepro-elf xstormy16-elf v850-elf vax-netbsdelf > visium-elf x86_64-darwin x86_64-linux-gnu xtensa-elf > > and checking that there were no changes in assembly. Also tested > in the normal way on aarch64-linux-gnu, powerc64-linux-gnu and > x86_64-linux-gnu. Could you also test powerpc64le-linux please? It is a primary platform. gcc112 is a nice fast machine. Segher