public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Joerg Sonnenberger <joerg@bec.de>
To: Joerg Sonnenberger <joerg@bec.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Fix inconsistent section flags
Date: Sat, 22 Jul 2017 22:38:00 -0000	[thread overview]
Message-ID: <20170722223756.GA14249@britannica.bec.de> (raw)
In-Reply-To: <20170717143547.GA23668@britannica.bec.de>

[-- Attachment #1: Type: text/plain, Size: 57 bytes --]

One more patch needed for another edge condition.

Joerg

[-- Attachment #2: varasm.c.diff2 --]
[-- Type: text/plain, Size: 688 bytes --]

Index: src/external/gpl3/gcc/dist/gcc/varasm.c
diff -u src/external/gpl3/gcc/dist/gcc/varasm.c:1.2 src/external/gpl3/gcc/dist/gcc/varasm.c:1.3
--- src/external/gpl3/gcc/dist/gcc/varasm.c:1.2	Mon Jul 17 19:53:10 2017
+++ src/external/gpl3/gcc/dist/gcc/varasm.c	Sat Jul 22 20:52:52 2017
@@ -6428,7 +6428,8 @@
 	   location.  -fmerge-all-constants allows even that (at the
 	   expense of not conforming).  */
 	ret = SECCAT_RODATA;
-      else if (TREE_CODE (DECL_INITIAL (decl)) == STRING_CST)
+      else if (DECL_INITIAL (decl) != NULL
+               && TREE_CODE (DECL_INITIAL (decl)) == STRING_CST)
 	ret = SECCAT_RODATA_MERGE_STR_INIT;
       else
 	ret = SECCAT_RODATA_MERGE_CONST;

  reply	other threads:[~2017-07-22 22:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 14:36 Joerg Sonnenberger
2017-07-22 22:38 ` Joerg Sonnenberger [this message]
2017-08-22 14:16   ` coypu
2017-08-28 18:26 ` Jeff Law
2017-08-28 18:50   ` Joerg Sonnenberger
2017-08-29 15:36   ` Joerg Sonnenberger
2017-09-01 16:26     ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170722223756.GA14249@britannica.bec.de \
    --to=joerg@bec.de \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).